March 2019 - Koha-bugs - lists.koha-community.org

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 86201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86201&action=ed… Bug 8775: (follow-up) Change column header to "Collection" This patch changes the table heading for ccode to be "Collection" instead of "Collection code." Current templates vary, but "Collection" is more logical because we show the description, not the code. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85912|0 |1 is obsolete| | Attachment #86190|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 86200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86200&action=ed… Bug 8775: Add collection code to lost report This patch adds a column for collection code to the lost items report. To test, apply the patch and run the lost items report. You should see a collection code column. Test column configuration for this table: Go to Administration -> Configure columns. Confirm that the "collection_code" column can be configured and that configuration choices are applied correctly. Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12533] Improve authority search result display
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 --- Comment #2 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 86199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86199&action=ed… Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12533] Improve authority search result display
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- It's a one line fix, I can provide a follow-up later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12533] Improve authority search result display
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |oleonard(a)myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #12 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #9) > We should use the more flexible way to retrieve an AV's value: > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > authorised_value => item.ccode ) Is this really a blocker for this bug? There are many existing instances of using AuthorisedValues.GetByCode for ccode. If this is a new best practice they could all be fixed in a separate bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #10) > (In reply to Jonathan Druart from comment #9) > > We should use the more flexible way to retrieve an AV's value: > > > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > > authorised_value => item.ccode ) > > > > That way, if items.ccode is not bind to an AV, or bind to a different one > > than CCODE, it will display the correct value. I know it's not how we did in > > all of the places they are displayed, but it should be the correct way to do > > :) > > What happens if it's not mapped? I know the normal plugin outputs the > content of the field. It should output the value, yes. > If you mapped another category, you are breaking a lot of things. I am not > sure if we should start officially supporting this. Not supporting, but keeping it in mind for new additions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #9) > We should use the more flexible way to retrieve an AV's value: > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > authorised_value => item.ccode ) > > That way, if items.ccode is not bind to an AV, or bind to a different one > than CCODE, it will display the correct value. I know it's not how we did in > all of the places they are displayed, but it should be the correct way to do > :) What happens if it's not mapped? I know the normal plugin outputs the content of the field. If you mapped another category, you are breaking a lot of things. I am not sure if we should start officially supporting this. -- You are receiving this mail because: You are watching all bug changes.

1 0