April 2019 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #190 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Note: The routine C4::Biblio::get_biblio_authorised_values does not longer exist! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #189 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I suspect a wrong resolution conflict here, see commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories The following line has been removed for years, and re-added by this patchset: + $oldbiblio->{'authorised_value_images'} = ($search_context->{'interface'} eq 'opac' && C4::Context->preference('AuthorisedValueImages')) || ($search_context->{'interface'} eq 'intranet' && C4::Context->preference('StaffAuthorisedValueImages')) ? C4::Items::get_authorised_value_images( C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'}, $marcrecord ) ) : []; At first glance I'd say we just need a patch removing the line. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8219] get_biblio_authorised_values embarrassingly inefficient
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16167 --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Well, not really, the method has been removed by commit 85e7d186ec2f0a30e479bc924a1023c73eefc28e Bug 16167: Remove Authorised value images prefs But the call has been re-added recently: commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories So, this bug is fixed, but we have another one running. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16167] New: Authorised value images may be removed
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167 Bug ID: 16167 Summary: Authorised value images may be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16041 The feature to attach an image to an authorised value does not seem to work perfectly and it's possible that nobody uses it. I'd suggest to discuss about that removal on this bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16041 [Bug 16041] StaffAuthorisedValueImages & AuthorisedValueImages preferences - impact on search performace -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 4274] Optionally allow sending cart without requiring login
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to David Cook from comment #9) > (In reply to Katrin Fischer from comment #8) > > A human being might still misuse the feature - I think it should be a choice > > for the library, so they can turn off 'non logged in cart sending'. > > Agreed. We actually have this implemented locally as an "anonymous cart" > system preference. I think most of our libraries have it turned off (ie > require login), but a few want anyone to be able to use the cart. Still have the code somewhere? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3) > Is this still valid? Yes, it could be a code cleaning. So far we have to test if userenv is defined before accessing a key, for instance: C4/Accounts.pm: my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; My fix would still be valid, but we still need a test: C4/Accounts.pm: my $branchcode = exist C4::Context->userenv->{branch} ? C4::Context->userenv->{'branch'} : undef; which actually makes less sense. A better approach could be to have a ->logged_in_user method, to retrieve a Koha::Patron object, representing the logged in user. But it is a quite huge work, and nobody will sign it off, and rebases will be tricky ;) Lowering severity for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5666] regexp edits to URL fields in bibliographic edit screens
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5666 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We do have a batch record modification tool now that supports changing 856$u using regex. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5561] Help on summary field in authority type editor
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5561 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9234] Koha's search code needs to be rewritten
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 5515, which changed state. Bug 5515 Summary: Leading 'and' in search never returns a result https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9233] Use unambiguous boolean operators for searches
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '19

29 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9233 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart(a)bobsown.com --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** Bug 5515 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0