April 2019 - Koha-bugs - lists.koha-community.org

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88102|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88831&action=ed… Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84859|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88829&action=ed… Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84842|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88828&action=ed… Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84841|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88827&action=ed… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #55 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88826&action=ed… Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #54 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88825&action=ed… Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #53 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88824&action=ed… Bug 8628: Digital signs - preferences and permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #52 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88823&action=ed… Bug 8628: Digital signs - Koha objects -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Apr '19

26 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #51 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 88822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88822&action=ed… Bug 8628: Digital signs - schema updates -- You are receiving this mail because: You are watching all bug changes.

1 0