April 2019 - Koha-bugs - lists.koha-community.org

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88669|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88739&action=ed… Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88668|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88738&action=ed… Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88667|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88737&action=ed… Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88666|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88736&action=ed… Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88665|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88735&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6759] Use a different account type for account renewals than for new accounts
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88615|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88732&action=ed… Bug 6759: Update existing accountlines for 'A' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6759] Use a different account type for account renewals than for new accounts
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88614|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88731&action=ed… Bug 6759: Split account creation and renewal charges Test plan: 1. Enable charging for patron enrolement 2. Add a new patron where the category is charged for 3. Note the charge of type 'Account management fee' 4. Renew the patron 5. Note the next charge of type 'Account management fee' 6. Apply patch 7. Repeat steps 1-6 and note the first charge will be of type 'Account creation fee' and the second of type 'Account renewal fee' 8. Bonus points, enable 'FeeOnChangePatronCategory' and check that when changing a patron from a free category to a charged one that a new 'Account renewal fee' is charged. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88606|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88729&action=ed… Bug 11573: (follow-up) Correction to accountype search on opac-user.pl With the update of accountype from 'Rent' to four distinct accountypes we need to update the search here to catch all four types of charge. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88605|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88728&action=ed… Bug 11573: Update of unit tests This patch updates the unit tests to reflect the changes to the core routines. The relevant changes are the removal of a hard coded 'description' and the splitting up of the 'Rent' accounttype into 'RENT', 'RENT_RENEW', 'RENT_DAILY' and 'RENT_DAILY_RENEW'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] Fine descriptions related to Rentals are untranslatable
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '19

25 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88604|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 88727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88727&action=ed… Bug 11573: Update existing accountlines for 'Rent' Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0