April 2019 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66269|0 |1 is obsolete| | --- Comment #63 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 88302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88302&action=ed… Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved Since bug 14695 it is possible to reserve more than one item per biblio Also fix bad use of $item -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66268|0 |1 is obsolete| | --- Comment #62 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 88301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88301&action=ed… Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66267|0 |1 is obsolete| | --- Comment #61 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 88300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88300&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88293|0 |1 is obsolete| | --- Comment #68 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 88298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88298&action=ed… Bug 15261: Check reserves while renewing an issue Test plan: - Create an issue (i.e from 15/09/2017 to 04/10/2017), - place a reserve on the same item from 05/10/2017 to 30/10/2017), - enable PreventCheckoutOnSameReservePeriod, - Check that you are not able to renew the issue. Rebased (2018-03-15) Rebased (2019-04-18) Rebased-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88292|0 |1 is obsolete| | --- Comment #67 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 88297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88297&action=ed… Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rebased on master (2016-03-11) Rebased on master (2016-06-23) Rebased on master (2017-03-23) Rebased on master (2018-03-15) Rebased on master (2019-04-18) Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Séverine Queune <severine.queune(a)bulac.fr> --- (In reply to Katrin Fischer from comment #29) > Next time as a separate follow-up patch please! ;) > > Looking at this again I have some issues, I am sorry to come up with this a > little lately :( > > 1) Usability > There is visual indicator to tell apart an already stored from a > changed/unsafed note. It's really easy to forget to press the button. > > If you happen to end your note with pressing "Enter" you trigger the error > message "No order selected" > > It really doen't work well for notes that are longer than the input field > is. They don't display in full and it's hard to move around in the input > field. > > I think I'd like this much better following the existing design pattern with > links and a modal (see basket summary). I am adding Owen in hope he has time > to take a look. > > 2) Search > Searching on the notes column doesn't work. > > 3) Export > The notes are not exported, neither using the "Export as CSV" nor the new > "Excel" export at the bottom of the table. Sorry Pierre-Marc, all the issues Katrin noticed on comment 29 are still present. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88213|0 |1 is obsolete| | --- Comment #81 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88296&action=ed… Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88212|0 |1 is obsolete| | --- Comment #80 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88295&action=ed… Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '19

18 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0