April 2019 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #145 from Michal Denar <black23(a)gmail.com> --- Created attachment 88178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88178&action=ed… Bug 15516: Fix translation issues - Use " inside _() - Merge two strings (PART_OF_A, HOLD_GROUP) Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #144 from Michal Denar <black23(a)gmail.com> --- Created attachment 88177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88177&action=ed… Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #143 from Michal Denar <black23(a)gmail.com> --- Created attachment 88176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88176&action=ed… Bug 15516: Set reserve-group.pl to be executable Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #142 from Michal Denar <black23(a)gmail.com> --- Created attachment 88175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88175&action=ed… Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #141 from Michal Denar <black23(a)gmail.com> --- Created attachment 88174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88174&action=ed… Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87828|0 |1 is obsolete| | Attachment #87829|0 |1 is obsolete| | Attachment #87830|0 |1 is obsolete| | Attachment #87831|0 |1 is obsolete| | Attachment #87832|0 |1 is obsolete| | Attachment #87833|0 |1 is obsolete| | Attachment #87834|0 |1 is obsolete| | Attachment #87835|0 |1 is obsolete| | Attachment #87836|0 |1 is obsolete| | Attachment #87837|0 |1 is obsolete| | Attachment #87838|0 |1 is obsolete| | Attachment #88038|0 |1 is obsolete| | Attachment #88039|0 |1 is obsolete| | Attachment #88125|0 |1 is obsolete| | --- Comment #140 from Michal Denar <black23(a)gmail.com> --- Created attachment 88173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88173&action=ed… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15496] Delete bibliographic record after moving last item to another record(s)
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org --- Comment #26 from Josef Moravec <josef.moravec(a)gmail.com> --- Looking good, passes QA tools, I just changed the 200 response code to 204, as needed by our API coding guidelines. Only one thing could be improved - I would like to see some styling on response message in UI. (span#del-bib-success, span#del-bib-failure selectors) I am adding Owen, he could have some idea I hope ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15496] Delete bibliographic record after moving last item to another record(s)
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88172&action=ed… Bug 15496: (QA follow-up) Change success status on api DELETE response code must be 204, not 200 according to our API coding guidelines Test plan: prove t/db_dependent/api/v1/biblios.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15496] Delete bibliographic record after moving last item to another record(s)
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88032|0 |1 is obsolete| | --- Comment #24 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 88171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88171&action=ed… Bug 15496: (QA Follow up) remove text/javascript Make the QA tool happy for html5 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0