April 2019 - Koha-bugs - lists.koha-community.org

[Bug 7867] Use consistent terminology for username and password
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '19

11 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley(a)catalyst.net.n | |z --- Comment #32 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- I started to fix this patch, then realised that tooltips don't display when hovering over the Login text in the OPAC, so the patch doesn't really work anymore. I am keen to standardise though, does anyone have any updated opinions on the solution for this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '19

11 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #147 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 8) Changes to syspref.sql are missing 9) There are some default values set in the database updat that can't go into kohastructure.sql, might have to go into a new SQL file in the installers. 10) Looking at the setup table I'll also need documentation, pretty please! Right now, I have no clue on how to use this. Good stuff too: Unit tests pass, new permission is good too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '19

11 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #146 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 87711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87711 Bug 14957: Merge rules system for merging of MARC records Review of attachment 87711: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=149…) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +262,3 @@ > =cut > > sub ModBiblio { 4) Changes to ModBiblio should be covered by unit tests. @@ +3615,4 @@ > return $record; > } > > +=head2 ApplyMarcMergeRules 5) New method needs to be covered by unit tests. ::: admin/marc-merge-rules.pl @@ +15,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use strict; > +use warnings; 6) Should be: Modern::Perl 7) Changes to kohastructure.sql are missing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '19

11 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #145 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Taking a first view here, starting with the QA script: 1) QA script failures: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-merge-rules.tt FAIL filters missing_filter at line 376 ( <input type="checkbox" name="batchremove" value="[% rule.id %]"[% IF rule.removemarked %] checked="checked"[% END %]/>) missing_filter at line 364 ( <td>[% rule.filter %]</td>) missing_filter at line 372 ( <a href="?op=remove&id=[% rule.id %]" title="Delete" class="btn btn-mini"><i class="fa fa-trash"></i> Delete</a>) missing_filter at line 317 ( <option value="[% module.id %]">[% module.name %]</option>) missing_filter at line 373 ( <a href="?op=edit&id=[% rule.id %]" title="Edit" class="btn btn-mini"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 363 ( <td>[% rule.module %]</td>) missing_filter at line 308 ( <tr id="[% rule.id %]" class="rule[% IF rule.edit %]-edit[% END %]">) missing_filter at line 315 ( <option value="[% module.id %]" selected="selected">[% module.name %]</option>) missing_filter at line 234 (<form action="[% script_name %]" method="GET">) missing_filter at line 328 ( <option value="[% preset %]">[% preset %]</option>) missing_filter at line 357 ( <button class="btn btn-mini" title="Save" id="doedit" value="[% rule.id %]"><i class="fa fa-check"></i> Save</button>) missing_filter at line 323 ( <td><input type="text" size="3" name="tag" value="[% rule.tag %]"/></td>) wrong_html_filter at line 373 ( <a href="?op=edit&id=[% rule.id %]" title="Edit" class="btn btn-mini"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 5 (<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" />) missing_filter at line 310 ( <td>[% rule.id %]</td>) missing_filter at line 385 (<form action="[% script_name %]" method="post">) missing_filter at line 365 ( <td>[% rule.tag %]</td>) missing_filter at line 241 (<form action="[% script_name %]" method="POST" id="marc-merge-rules-form">) wrong_html_filter at line 372 ( <a href="?op=remove&id=[% rule.id %]" title="Delete" class="btn btn-mini"><i class="fa fa-trash"></i> Delete</a>) missing_filter at line 362 ( <td>[% rule.id %]</td>) missing_filter at line 263 ( <option value="[% module.id %]">[% module.name %]</option>) missing_filter at line 273 ( <option value="[% preset %]">[% preset %]</option>) missing_filter at line 322 ( <td><input type="text" size="5" name="filter" value="[% rule.filter %]"/></td>) FAIL forbidden patterns forbidden pattern: Do *not* include full path to css files, use the Asset TT plugin (bug 20538) (line 5) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 372) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 373) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 14) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 357) forbidden pattern: Attribute type should not be used for style tags (bug 20054) (line 8) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 302) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 358) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 301) OK git manipulation FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) OK spelling FAIL tt_valid lines 334, 335, 340, 341, 346, 347, 352, 353, 376 OK valid_template FAIL Koha/MarcMergeRule.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'store' OK spelling OK valid FAIL Koha/MarcMergeRules.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for delete POD is missing for find_or_create POD is missing for object_class POD is missing for operations POD is missing for update POD is missing for validate OK spelling OK valid FAIL Koha/MarcMergeRule.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'store' OK spelling OK valid FAIL Koha/MarcMergeRules.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for delete POD is missing for find_or_create POD is missing for object_class POD is missing for operations POD is missing for update POD is missing for validate OK spelling OK valid 2) Please merge your 3 atomic update SQL files into one .perl file. That will make the RM happy. 3) There is no sign-off line on the patch? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19265] New: Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '19

11 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Bug ID: 19265 Summary: Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '19

10 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Tests are still failing for me: t/db_dependent/Serials.t .. 2/46 # Failed test 'NewSubscription should not set subscriptionhistory opacnotes' # at t/db_dependent/Serials.t line 95. # got: undef # expected: '' # Failed test 'NewSubscription should not set subscriptionhistory librariannotes' # at t/db_dependent/Serials.t line 96. # got: undef # expected: '' t/db_dependent/Serials.t .. 14/46 # Looks like you failed 2 tests of 46. t/db_dependent/Serials.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/46 subtests Wondering, should we correct the old data? I know have a mix of '' and NULL in my db. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11057] Bootstrap theme: Don't hide language chooser below the fold
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '19

10 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I wonder if this is still needed. The display of the language chooser appears ok now to me, especially with bug 22680. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13325] Add logs for budgets and funds
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '19

10 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 karen.fellows(a)citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen.fellows@citruslibrari | |es.org --- Comment #6 from karen.fellows(a)citruslibraries.org --- Agree with Rhonda and Sandy. It definitely would be nice to have an audit trail/log for the funds and budgets. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13325] Add logs for budgets and funds
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '19

10 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Sandy Allgood <sandy.allgood(a)citruslibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandy.allgood@citruslibrari | |es.org --- Comment #5 from Sandy Allgood <sandy.allgood(a)citruslibraries.org> --- This would be a really nice feature to track our transfer of funds and budgets, not only for history but for our County auditing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip)
by bugzilla-daemon＠bugs.koha-community.org 10 Apr '19

10 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #11 from Liz Rea <wizzyrea(a)gmail.com> --- You can do this with the TT notices on the slips, with the code snippet provided by Josef. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0