May 2019 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Failed QA --- Comment #73 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- "Pushed for QA" still doesn't mean what you think ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Pushed for QA --- Comment #72 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- (In reply to Magnus Enger from comment #66) > attachment 88300 [details] [review] has merge markers (<<<<) in it. Maybe > the rebase was not complete? Thanks for pointing that out :) did a re-rebase and re-upload, everything applies fine now (still asking for QA though) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88303|0 |1 is obsolete| | --- Comment #71 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 90147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90147&action=ed… Bug 11999: Remove the "biblio already reserved" check in CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88302|0 |1 is obsolete| | --- Comment #70 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 90146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90146&action=ed… Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved Since bug 14695 it is possible to reserve more than one item per biblio Also fix bad use of $item -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88301|0 |1 is obsolete| | --- Comment #69 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 90144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90144&action=ed… Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90142|0 |1 is obsolete| | --- Comment #68 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 90143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90143&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 28 May '19

28 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88300|0 |1 is obsolete| | --- Comment #67 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 90142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90142&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 May '19

27 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.

1 0