May 2019 - Koha-bugs - lists.koha-community.org

[Bug 10492] Translation problems with TT directives in po files
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10492] Translation problems with TT directives in po files
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 89365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89365&action=ed… Bug 10492: Translation problems with TT directives in po files This patch implements the replacement of TTvariables '[%...%]' with normal placeholders '%s' for text inside HTML tags (eg. img, meta, input) The replacement is done in two files: * xgettext.pl, used on create/update, so TTvars are not found on the text to translate (msgid) * tmpl_proccess3.pl, used on install time, so the correct translation is found (msgstr) and the right TTvar is put on the translated text. To test: Before applying the patch 1) Update your favorite language cd misc/traslator perl translate update xx-YY 2) Build a list (ini.txt) of 'msgid' to do a comparison msgcat --no-wrap --use-first po/xx-YY-*po -o - | egrep "^msgid" | sort > ini.txt 3) Apply the patch 4) Update your favorite language, again cd misc/traslator perl translate update xx-YY 5) Build a final list (end.txt) of 'msgid' to do a comparison msgcat --no-wrap --use-first po/xx-YY-*po -o - | egrep "^msgid" | sort > end.txt 6) Compare both files, you must find (most) TTvars replaced by '%s' diff ini.txt end.txt for example: < msgid "Translate item type [% itemtype.itemtype | html %]" > msgid "Translate item type %s" < msgid "Holds on this item: [% item_loo.item_holds | html %] / Total holds on this record: [% item_loo.holds | html -%]" > msgid "Holds on this item: %s / Total holds on this record: %s" < msgid "tag_anchor_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]" > msgid "tag_anchor_%s_%s%s" < msgid "[% innerloo.tag_lib | html %] - Click to Expand this Tag" > msgid "%s - Click to Expand this Tag" 7) Translate one of the examples, with more than one variable if possible, for example this text in xx-YY-staff-prog.po > msgid "Holds on this item: %s / Total holds on this record: %s" Check it's not marked as 'fuzzy' 8) Apply the translation perl translate install xx-YY 9) Check the translated string has all variables in the right order edit koha-tmpl/intranet-tmpl/prog/es-ES/modules/tools/batchMod-edit.tt around line '187', first '[% item_loo.item_holds | html %]', then '[% item_loo.holds | html -%]' on this case, or use another example If approved this patch can be backported to current stable versions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10492] Translation problems with TT directives in po files
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |bgkriegel(a)gmail.com |ity.org | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Katrin Fischer from comment #3) > Searching for [% in the po files for 19.05 finds 69 results. A lot of those > are like: > > Koha [% Version %] > > I am not sure why those exist yet. I would have expected Koha %s. They exist because they belong to 'attributes' in HTML tags, for example 'alt' in 'img', 'value' in inputs, or 'content' in 'meta'. In this particular case, on line 5 of opac-tmpl/bootstrap/en/includes/doc-head-close.inc there is <meta name="generator" content="Koha [% Version | html %]" /> Each line on each TT file is 'tokenized', and TTvariables are replaced with '%s'. But an HTML tag (i.e. <meta ../>) is 'tokenized' as such, so no replacement is made there; only the text of some attributes is extracted in order to translate them. Ideally we should no use TTvariables inside tag attributes, but it's useful :) I'll try to write a patch to (partially) 'fix' this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 22853] New: El Diablo
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22853 Bug ID: 22853 Summary: El Diablo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aldichrisna57(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 89361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89361&action=ed… El Diablo Terkentod By El Diablo Gans from Chicky Chucks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 22852] New: El Diablo Was Here
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22852 Bug ID: 22852 Summary: El Diablo Was Here Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aldichrisna57(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 89358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89358&action=ed… El Diablo Was Here El Diablo Was Here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 3309] Deleting authorized values when data exists
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21466 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4) > Authorised values are used in so many places and can be user defined too - > it seems impossible to introduce a reliable check here. ;.. For AVs linked to biblio frameworks I added a test to the "search for inconsistencies" script, see bug 21466. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10910] Add a warn when deleting a patron with pending suggestions
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5) > Created attachment 89360 [details] [review] > Bug 10910: Add a warning when deleting a patron with pending suggestions Something like that? Should we also add a warning in the batch deletion tool? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10910] Add a warn when deleting a patron with pending suggestions
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 89360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89360&action=ed… Bug 10910: Add a warning when deleting a patron with pending suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10958] no need for home link on home page
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I like the consistency of the Home link on the start page. Whatever the styling it makes clear that this is the start page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10981] changing focus when alert on check in
by bugzilla-daemon＠bugs.koha-community.org 05 May '19

05 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10981 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We now use modals and other ways to block entry of another barcode. Marking FIXED. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0