June 2019 - Koha-bugs - lists.koha-community.org

[Bug 10113] Currency and cost calculation problem in acquisition
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113 --- Comment #5 from Saiful Amin <saiful(a)semanticconsulting.com> --- If I understand the bug report correctly, it is about calculation not happening automatically. Manual fixing of final amount is always an option. It is the 'automatic calculation' that breaks in some cases. In my tests in the past, currency with white-space is an issue that results in this behavior. I have not tested this in recent versions, but I always advise everyone not to have white-space in the currency code. It just avoids the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23106 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106 [Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines' screen -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23105 [Bug 23105] Library patrons should have the ability to apply their credit against their debts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #157 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 3) was more an observation at this point. If you could rebase and take care of 4) I'd love to continue testing. This is a bit "too big" overall... and shoudl have been split into smaller bits and pieces...(too late now, I know, but we've seen this with a lot of things) But I hope we can make it move. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22679] New: circulation_rules are not deleted when accompanying issuingrules are deleted
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 Bug ID: 22679 Summary: circulation_rules are not deleted when accompanying issuingrules are deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To recreate: 1 - Browse to Administration ->Circulation and fines 2 - Add a rule with a number for 'Total checkouts allowed' 3 - check the db: select * from circulation_rules 4 - The rule should be there 5 - Delete the rule from the staff interface 6 - Check the DB 7 - The rule is not deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 22759] New: Circulation rules for maxissueqty are applied per branch even for defaults
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22759 Bug ID: 22759 Summary: Circulation rules for maxissueqty are applied per branch even for defaults Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To test: 1 - Find a title in the catalog, add 8 items, all of a single itemtype, 4 for branch A, four for branch B 2 - Remove any specific circ rules 3 - Set a default circ rule for the itemtype used above, limiting the max issue quantity to 3 4 - Find a patron and checkout the items from branch A 5 - You should be allowed ot checkout 3, but the fourth should trigger 'too many' 6 - Now checkout the items from branch B, again you can checkout 3 and not four 7 - You shouldn't be allowed 3 from each library :-( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 22619] New: Adding a new circ rule with unlimited checkouts is broken
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22619 Bug ID: 22619 Summary: Adding a new circ rule with unlimited checkouts is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- On bug 18925 we missed a case of fixing null/empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 22489] New: Onboarding tool fails due to inserting maxissueqty into IssuingRule
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Bug ID: 22489 Summary: Onboarding tool fails due to inserting maxissueqty into IssuingRule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: hayleymapley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- When going through the onboarding process, the tool fails on submit of Step 5 - creating an issuing rule. This is due to the maxissueqty column having been removed from the IssuingRules table and added to the CirculationRules table but redundant code still exists in onboarding.pl. As you can see below the maxissueqty variable is being added to the params hash which is used to make the new issuing rule. if ( $step == 5 ) { if ( $op eq 'add_validate_circ_rule' ) { #If no libraries exist then set the $branch value to * my $branch = $input->param('branch') || '*'; my $type = $input->param('type'); my $branchcode = $input->param('branch'); my $categorycode = $input->param('categorycode'); my $itemtype = $input->param('itemtype'); my $maxissueqty = $input->param('maxissueqty'); my $issuelength = $input->param('issuelength'); my $lengthunit = $input->param('lengthunit'); my $renewalsallowed = $input->param('renewalsallowed'); my $renewalperiod = $input->param('renewalperiod'); my $onshelfholds = $input->param('onshelfholds') || 0; $maxissueqty =~ s/\s//g; $maxissueqty = undef if $maxissueqty !~ /^\d+/; $issuelength = $issuelength eq q{} ? undef : $issuelength; my $params = { branchcode => $branchcode, categorycode => $categorycode, itemtype => $itemtype, maxissueqty => $maxissueqty, renewalsallowed => $renewalsallowed, renewalperiod => $renewalperiod, issuelength => $issuelength, lengthunit => $lengthunit, onshelfholds => $onshelfholds, }; my $issuingrule = Koha::IssuingRule->new($params); eval { $issuingrule->store; }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #156 from David Gustafsson <glasklas(a)gmail.com> --- Thanks for the feedback. I more or less agree with all of pointed out issues and not that it matters but those design choices, including the somewhat cryptic naming of modules, were not made by me but comes from the original version of the patch. I have not addressed them since just wanted to spend the minimal effort for the patch to get into Koha and have focused on the issues brought up thus far. But at least 4) has been brought up before and I should perhaps have fixed that in the current iteration of the patch since the modules are added in an atomic update and I saw no other instance where data is inserted in kohastructure.sql. Thus if making a fresh Koha installation this data will be missing which is not acceptable. Since the modules are not invoked dynamically in the code, but are hard coded, it makes more sense for them to be defined as constants, which would resolve the database population issue. I think this should be pretty uncomplicated to refactor, by hard coding the modules in the template (to make the label translatable) making that the authoritative source. In my opinion there is a rather urgent need for having translatable strings in Koha without (ab)using the template system, but that is out of the scope of this bug. About 4) I agree that is to use borrowernumber is not pretty, I guess the reason it is used instead of userid is it is available in scope without having to look up the userid in a database call, but userid (username) would be better. I also agree that it is probably a very rare use-case to need to specify rules per user, but on the other hand, since the cost of providing this context is relatively low, it might also be a little bit presumptuous to remove the option. For example, it is a simple way to allow certain super-users to override all rules by creating a wildcard "allow all" rule without having to reserve a user category for this purpose. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15558] To rename the patron expiration date field in patron screen
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15558 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- I think that even though it is not visible in the interface, using "member" instead of "patron" in this patch is contrary to terminology guidelines. I think this patch also misses an instance in the patron edit form: It doesn't add the new class to the label in the case that expiration date is mandatory. -- You are receiving this mail because: You are watching all bug changes.

1 0