June 2019 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90389|0 |1 is obsolete| | --- Comment #86 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 90470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90470&action=ed… Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12537] editions tab showing on bibs with more than one ISBN
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90464|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 90468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90468&action=ed… Bug 12537: Don't retrieve XISBN results for the same biblionumber For a biblio with multiple ISBNS we sometimes get our own record back when check XISBN, we should test for this To test: 1 - Edit a record in the catalogue, add two isbns: 0521240670 0521284198 2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions 3 - View the record in staff and OPAC 4 - You should see editions tab pointing to the same record 5 - Apply patch 6 - Reload the record details, you should no longer see editions tab 7 - Add the second ISBN to another record 8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN 9 - prove -v t/db_dependent/XISBN.t NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12537] editions tab showing on bibs with more than one ISBN
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10589] Override OpacHiddenItems based on Patron Branch
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #49 from M. Tompsett <mtompset(a)hotmail.com> --- Doh! That doesn't quite work, because homebranch is on item. So, you want to pass patron to hidden_in_opac on items... Okay... Hmm... thinking.... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10589] Override OpacHiddenItems based on Patron Branch
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #48 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #47) > Please take a look at bug 22454 and bug 22455. The rationale is that if you > have the biblio object, you can know all that is needed regarding hiding in > OPAC without fetching MARC data or complex calculations. And if we were to > add parameters like category and library, I would rather pass the > Koha::Patron object altogether. > This check, with bug 22457 in mind could be written: > > my $should_hide = ( $patron->category->overrides_opac_hidding_policy or > $patron->library->overrides_opac_hidding_policy ) > ? 0 > : 1; > > while ( my $biblio = $biblios->next ) { > next if $biblio->hidden_in_opac and $should_hide; > do_your_things(); > } > > This check should be written on the controller script. Doesn't quite work. The idea is: if (! defined $patron) { $globally_override = 0; } elsif (! defined $patron->category) { $globally_override = 0; } else { $globally_override = $patron->category->globally_overrides_opac_hiding; } while ( my $biblio = $bilbios->next ) { if (! defined $patron) { $locally_override = 0; } else { $locally_override = ($patron->branchcode ne $biblio->homebranch) ? 0 : $patron->category->overrides_opac_hiding_policy_locally; } $should_show = $globally_override || $locally_override; $should_hide = ! $should_show; next if $biblio->hidden_in_opac && $should_hide; do_your_things(); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22953] New: Markup warning in OPAC user summary template
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '19

10 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Bug ID: 22953 Summary: Markup warning in OPAC user summary template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- If the AllowCheckoutNotes system preference is turned on, validating the user summary page in the OPAC (opac-user.pl) will return warnings: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 1887] Managing Suggestions - hold books for patron who requested
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '19

10 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 --- Comment #5 from Barbara Johnson <barbara.johnson(a)bedfordtx.gov> --- That should have been bug #19358 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15051] 245 Marc Field Order
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '19

10 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |nick(a)bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- In testing the fields appear in the order they are cataloged,we can adjust the order in both editors, closing this one now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12537] editions tab showing on bibs with more than one ISBN
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '19

10 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com, | |oleonard(a)myacpl.org Assignee|oleonard(a)myacpl.org |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0