July 2019 - Koha-bugs - lists.koha-community.org

[Bug 13325] Add logs for budgets and funds
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '19

10 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 koha-US bug tracker <bugzilla(a)koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla(a)koha-us.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '19

10 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '19

10 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '19

10 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Thanks for testing Josef and Owen! I think I've addressed all your points in comment #6 Owen. If you two could please re-test again that would be much appreciated. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '19

10 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 --- Comment #7 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 91433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91433&action=ed… Bug 13552: (follow-up) Add debar option to batch patron modification As per test feedback I've changed wording from debarrment to restriction Added insertion into the borrower_debarments table and removal from borrower_debarments table (and borrowers.debarred and borrowers.debarredcomment) when either 'Restriction expiration' or 'Restriction comment' are ticket to be disabled/deleted. Test plan (please follow this instead of following test plan in the first patch): 1. Go to Tools > Batch patron modification 2. Input the cardnumbers of several (undebarred/unrestricted) patrons and submit 3. Notice there is no input for setting Restriction expiration date or Restriction comment Also notice in the list of matching borrowers at the top of the page there is no display of the 'Restriction expiration' or 'Restriction comment' values for the patron 4. Apply patch 5. Restart memcached and plack 6. Refresh the page notice 'Restriction expiration' (a date picker input) and 'Restriction comment'are now input options Also notice in the table at the top of the page 'Restriction expiration' and 'Restriction comment' are shown on the far right of the table (you may need to scroll to see this) 7. Pick a date in the 'Restriction expired' datepicker and write in text into the 'Restriction comment' field and submit 8. Notice in the next loaded page the selected patrons have the 'Restriction expiration' and 'Restriction comment' values you entered 9. Query the borrower_debarments database table and check that the new debarments are added to this table 10. Go back to the Batch patron modification page and re-input the same cardnumbers 11. Write text into the 'Restriction comment' field and don't pick a 'Restriction expiration' value and submit 12. Notice in the next loaded page the selected patrons have the 'Restriction expiration' value of 9999-12-31 and 'Restriction comment' value you just entered 13. Query the borrowers table and notice the borrowers.debarred value for the modified patrons is '9999-12-31' and the borrower.debarredcomment is what you inputted in step 11 14. Query the borrower_debarments table and notice the expiration value is NULL and the comment value is set to what you entered in step 11 Also note the addition of the new debarment has not removed the existing debarment on the patrons 15. Click on the cardnumber link of one of the patrons and notice the red text on their patron account page informing you they are restricted until the date you set 16. In the Koha home directory enter Koha shell: sudo koha-shell <instancename> 17. Run: prove xt 18. All tests should pass 19. Repeat step 10 and tick the checkbox beside the 'Restriction expiration' field and submit 20. In the next loaded screen notice the 'Restricted expiration'and 'Restricted comment' are empty Check the borrower_debarments table and notice all restrictions for the patron are removed. Check the borrowers table and notice the debarred and debarredcomment fields are empty for the patrons 21. Repeat steps 10 and 11 to make a new restriction 22. Repeat step 19 and this time check the 'Restriction comment' field and submit and observe that also clears the restriction in the next loaded page, in the borrower_debarments and borrowers table 23. Sign off Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] Untranslatable "Uncertain" text in acq
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '19

09 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2486] Show user comments in staff client
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '19

09 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is still valid - the comments show in the OPAC, but not in staff. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '19

09 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #79 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- I see test "alreadyReserved" on same biblio still exists inCanBookBeReserved. It should be removed says "Remove 'alreadyReserved' check in CanBookBeReserved". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '19

09 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 BASE Library Consortium <baselibrary.consortium(a)nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18543 CC| |baselibrary.consortium@nhs. | |net Priority|P5 - low |P4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13552] Add debar option to batch patron modification
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '19

09 Jul '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- In my test this worked to update the borrowers table, but nothing was added to the borrower_debarments table. Both are necessary. Also: If you add a restriction without an "until" date I think it is supposed to be '9999-12-31' in borrowers and NULL in borrower_debarments. At the same time could you update the labels? The default English translation should use the term "Restriction." -- You are receiving this mail because: You are watching all bug changes.

1 0