August 2019 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #126 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92426&action=ed… Bug 8367: Altered expirationdate calc in Koha/Hold.pm and altered C4/Reserves/CancelExpiredReserves() Added check for holidays to expirationdate calculation in Koha/Hold.pm so the expirationdate respects holidays as the lastpickupdate does. Changed C4/Reserve/CancelExpiredReserves() to check the reserves.lastpickupdate rather than rserves.expirationdate. Therefore it will now automatically expire holds if they have not been picked up within the time period specified in the hold pickup delay defined in the issuing rules (which is added to reserves.waitingdate to calculate the reserves.lastpickupdate) AND the ExpireReservesMaxPickUpDelay syspref is enabled. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92413|0 |1 is obsolete| | Attachment #92416|0 |1 is obsolete| | Attachment #92417|0 |1 is obsolete| | Attachment #92418|0 |1 is obsolete| | Attachment #92419|0 |1 is obsolete| | Attachment #92420|0 |1 is obsolete| | Attachment #92421|0 |1 is obsolete| | Attachment #92422|0 |1 is obsolete| | Attachment #92423|0 |1 is obsolete| | Attachment #92424|0 |1 is obsolete| | --- Comment #125 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92425&action=ed… Bug 8367: How long is a hold waiting for pickup at a more granular level You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. The lastpickupdate-column is set based on the given instruction and lands only on an open library day. Also cancel_expired_reserves.pl now cancels only on open library days after the last pickup date has expired. And waitingreserves.pl respects the new DB column. If ReservesMaxPickUpDelay is not set prior to the databaseupdate, the holdspickupwait-directive is never defined, thus disabling this feature until the holdspickupwait is set. If the issuingrules holdspickupwait is 0 or less, this feature is disabled. So each issuingrule can disable this feature for the material it matches, while being fully functional with other rules. This patch adds: - a new column in the issuing rules, including help topics. - a new column reserves.lastpickupdate (+old_reserves) It contains the waitingdate + the corresponding "holds pickup wait". Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupwait - a new function C4::Reserves::MoveWaitingdate() to help in testing this feature. - a new function C4::Reserves::GetLastPickupDate() to calculate the proper date from Calendar. This patch removes: - the ReservesMaxPickUpDelay syspref. - the ExpireReservesOnHolidays syspref, because it became obsolete due to the changes in handling the last pickup date with Koha Calendar. - Also removes a code section from C4::Letters::_parseLetter() which worked blatantly disrespectfully towards Koha Calendar. - TODO figure out how to rename existing letter placeholders <<expirationdate>> with <<lastpickupdate>> Unit tests included. $$$$$$$$$$$$$ $ TEST PLAN $ $$$$$$$$$$$$$ 0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF 'ReservesMaxPickUpDelay' is bigger than 0. Otherwise existing reserves won't get UPDATEd with the new lastpickupdate-values. ****** ****** *** *** *** TEST: BASIC WORKFLOW * ****** ****** 1. Check there is no regression with a normal reserve workflow. 2. Add one or more issuingrules. 3. Update the new column 'Holds pickup wait' in your issuing rules. 4. In the following 3 templates of staff client, you can see the 'Last pickup date' for a hold -circ/circulation.pl, Circulation>Check outs>Search for Patron>Holds tab -circ/waitingreserves.pl Circulation>Holds awaiting pickup -members/moremember.pl Patrons>Search for patron>Holds tab 5. In opac-user.pl the last pickup date is displayed in the Status column if available. 6. According to a library and an item type, the lastpickupdate value will be equal to the waiting date + the "holds pickup wait" defined moved to the next open library day. ** ** ** ** ** ** *** *** *** TEST: RESPECTING CALENDAR HOLIDAYS * ** ** ** ** ** ** 1) Create and trap a hold 2) View waitingreserves.pl (Circulation>Holds awaiting pickup), note the last pickup date, and the pickup location 3) Cancel this hold 4) Edit the calendar for the given location, and make the pickup date a single, unrepeated, holiday. Then make the next day a weekly repeating holiday. Then make the next two days an annual holiday repeatable every year. 5) Repeat step 2 6) View waitingreserves.pl, the last pickup date for this new hold should now be increased by four days. ** ** ** ** ** ** *** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION * ** ** ** ** ** ** 1. Modify the HOLD_SLIP, add <<reserves.lastpickupdate>> and <<reserves.waitingdate>> somewhere. 2. Catch a hold for a borrower and print the slip. Verify that the lastpickupdate is actually (currentdate + the 'Holds pickup wait' in your issuing rules) in days. 3. See the members/notices.pl for the message queued and verify that the lastpickupdate-placeholder is set in your desired datetime format and that it is not on a holiday. Verify that the waitingdate is today. Originally Authored-by: Joonas Kylmälä <j.kylmala(a)gmail.com> Taken up by: Hayley Mapley and Alex Buckley (Catalyst IT) Sponsored-by: Brimbank District Council -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #124 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92424&action=ed… Bug 8367: Fixing display of lastpickupdate Changed circ/waitingreserves.pl to correctly display lastpickupdate in Circulation>Holds awaiting pickup. Changed includes/holds-table.inc to display lastpickupdate in opac-user.pl in Holds tab. Sponsored-by: Brimbank District Council Authored-by: Hayley Mapley and Alex Buckley (Catalyst IT) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #123 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92423&action=ed… Bug 8367: Fixes to make the reserves workflow work with new schema Sponsored-by: Brimbank library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #122 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92422&action=ed… Bug 8367: (follow-up) Updates to DBIx class files Ran the update_dbix_class_files.pl script to regenerate the Koha/Schema/Result/ files again to match the database changes Making the atomicupdate file idempotent Sponsored-by: Brimbank Library, Australia Authored-by: Hayley Mapley and Alex Buckley -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #121 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92421&action=ed… Bug 8367: reserves.lastpickupdate calculation checks and uses ExcludeHolidaysFromMaxPickUpDelay syspref Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #120 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92420&action=ed… Bug 8367: Fixed how expirationdate is calculated when ExcludeHolidaysFromMaxPickUpDelay syspref is enabled Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #119 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92419&action=ed… Bug 8367: Altered expirationdate calc in Koha/Hold.pm and altered C4/Reserves/CancelExpiredReserves() Added check for holidays to expirationdate calculation in Koha/Hold.pm so the expirationdate respects holidays as the lastpickupdate does. Changed C4/Reserve/CancelExpiredReserves() to check the reserves.lastpickupdate rather than rserves.expirationdate. Therefore it will now automatically expire holds if they have not been picked up within the time period specified in the hold pickup delay defined in the issuing rules (which is added to reserves.waitingdate to calculate the reserves.lastpickupdate) AND the ExpireReservesMaxPickUpDelay syspref is enabled. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '19

22 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #118 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 92418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92418&action=ed… Bug 8367: Moved database update out of updatedatabase.pl into atomicupdates dir -- You are receiving this mail because: You are watching all bug changes.

1 0