August 2019 - Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #217 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92311&action=ed… Bug 14570: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #216 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92310&action=ed… Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #215 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92309&action=ed… Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #214 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92308&action=ed… Bug 14570: Add error handling to Koha::Patron::Relationship->store This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. There's also catching on possible broken constraints and throwing a new exception Tests are added for both the new exceptions and the changes to Koha::Patron::Relationship. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patron/Relationship.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #213 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92307&action=ed… Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #212 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92306&action=ed… Bug 14570: (QA follow-up) Fix issues in Guarantor context Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #211 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92305&action=ed… Bug 14570: (QA follow-up) Fix issues in Guarantee context Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #210 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92304&action=ed… Bug 14570: Update schema files [Do Not Push] Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 16 Aug '19

16 Aug '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #209 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 92303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92303&action=ed… Bug 14570: (follow-up) Fix patron type when "add child" button is pressed Signed-off-by: Agustin Moyano <agustinmoyano(a)theke.io> Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0