September 2019 - Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #71 from Lari Taskula <lari.taskula(a)hypernova.fi> --- (In reply to Lari Taskula from comment #63) > We are also trying to solve this issue. About a month ago I created some > patches for the National Library of Finland to test within the Finnish Koha > fork. I did not yet rebase those patches for master, but they can be found > in this PR > > https://github.com/KohaSuomi/Koha/pull/104 > > Sorry for causing duplicate work. I should had mentioned this as I started > the task. Here are my patches from GitHub, rebased on current master branch. I didn't test team Lyon's patch, but it seems the main difference is that this version displays a more specific error message "Transfer is forbidden between [% Branches.GetName( holdingbranch ) %] (item's current library) and [% LoginBranchname | html %]." The location for logic is also different. Mine checks transfer limits in CanBookBeReturned() while the original patch does it in AddReturn(). Not sure if it currently makes a difference, but it could help covering some edge cases. AddReturn of course internally uses CanBookBeReturned so I suppose this is more appropriate place to add the logic into. But as the original patch, this is also missing unit tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #70 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93196&action=ed… (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #69 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93195&action=ed… (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of CanBookBeReturned To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Lari Taskula <lari.taskula(a)hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93193|0 |1 is obsolete| | --- Comment #68 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93194&action=ed… (ANOTHER IMPLEMENTATION) Bug 7376: Refactoring subroutines CanBookBeReturned: - Take Koha::Item as parameter instead of HASHref of an item To test: 1. cd into your Koha root directory 2. grep -rn 'CanBookBeReturned(' 3. Make sure all returned occurences are using Koha::Item Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #67 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93193&action=ed… Bug 7376: Refactoring subroutines CanBookBeReturned: - Take Koha::Item as parameter instead of HASHref of an item To test: 1. cd into your Koha root directory 2. grep -rn 'CanBookBeReturned(' 3. Make sure all returned occurences are using Koha::Item Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #66 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93192&action=ed… (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '19

27 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #65 from Lari Taskula <lari.taskula(a)hypernova.fi> --- Created attachment 93191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93191&action=ed… (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of CanBookBeReturned To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes -- You are receiving this mail because: You are watching all bug changes.

1 0