September 2019 - Koha-bugs - lists.koha-community.org

[Bug 11622] Add ability to pay fees and fines from OPAC via PayPal
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 --- Comment #77 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- *** Bug 15335 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #38 from David Cook <dcook(a)prosentient.com.au> --- The protocol for memcached actually looks super straightforward: https://github.com/memcached/memcached/blob/master/doc/protocol.txt So we could probably mock a server easily enough. I took a little look using netcat but the client seemed to time out super quickly, although the client looks configurable in that respect. netcat -l localhost -p 50000 -vv Listening on [localhost] (family 0, port 50000) Connection from localhost 37910 received! add ckey 0 0 4 cent -- But mocking the server we could introduce other problems. I'm going to have some lunch in any case (at 3pm...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #37 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 92931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92931&action=ed… [Draft] Integration test Koha::Cache and memcached This test is not 100% reliable. When run with Cache::Memcached::Fast, it will usually generate errors, but not always. When run with Cache::Memcached::Fast::Safe, it never generates errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #36 from David Cook <dcook(a)prosentient.com.au> --- Actually testing Koha::Cache directly only looked like it was working. I think I'm having namespacing issues... should hopefully have something better soon... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #35 from David Cook <dcook(a)prosentient.com.au> --- Ok so C4::Context calls the following which creates a singleton Koha::Cache in the process where C4::Context is first loaded (after it's compiled): my $syspref_cache = Koha::Caches->get_instance('syspref'); It looks like the $syspref_cache is the same object shared between all the child processes... which should mean they all are using the same socket as well... I don't know why this isn't working. It should be working (or rather causing errors). So I'm going to go one step lower and just try the test using Koha::Cache directly. Oh yes that's much better. There has to be some logic in C4::Context throwing me off... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #34 from David Cook <dcook(a)prosentient.com.au> --- I've tried using C4::Context->preference() instead of using Cache::Memcached::Fast directly, but it's much less reliable, even when including Koha::Caches->flush_L1_caches() after every call... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #33 from David Cook <dcook(a)prosentient.com.au> --- Martin et al: Take a look at that draft integration test I wrote? Using 10 child processes and semi-randomized highish-volume Memcached lookups, I'm able to seemingly reliable reproduce the problem every time with Cache::Memcached::Fast and never reproduce it with Cache::Memcached::Fast::Safe. I'm going to look at doing a more Koha-specific version just now... but thought I'd share what I have as I go. At a glance, the Memcached protocol doesn't look that hard either, so a person could theoretically mock the server within the test. I think the problem is with the client rather than the server, but mocking the server would remove the dependency on the Memcached server... but I'll leave that up to Martin to make a call on that one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #32 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 92926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92926&action=ed… [Draft] Integration test for testing memcached client -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #31 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #30) > Adding more entropy is helping. Now I can reproduce it every single time I > run my test. And when I swap it out with the Safe module... no errors on any of my runs. Hoping to have a unit test ready soon... funnily enough by sharing an inherited file handle between all the processes... heh -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13193] Make Memcached usage fork safe
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '19

18 Sep '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #30 from David Cook <dcook(a)prosentient.com.au> --- Adding more entropy is helping. Now I can reproduce it every single time I run my test. -- You are receiving this mail because: You are watching all bug changes.

1 0