January 2020 - Koha-bugs - lists.koha-community.org

[Bug 24018] New: No need to die "Not logged in"
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '20

01 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 Bug ID: 24018 Summary: No need to die "Not logged in" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18403, 20489 There is a wrong pattern in several controller files: my $logged_in_user = Koha::Patrons->find( $loggedinuser ) or die "Not logged in"; This has been introduced by commit cee2cf9ff927504f9c24f6519462a7d702c5c27d Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos Which noted: Note that the 'or die "Not logged in";' part should not be needed, but... who trusts C4::Auth? I think it could be used as a safeguard later. I am willing to sed and remove them if required. Since we prevent DB user login it's no longer needed. It is time to remove it, as we trust our code (don't you?) and it can be confusing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 3426] Change itemcallnumber system preference to allow multiple tags
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy(a)bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #19 from Joy Nelson <joy(a)bywatersolutions.com> --- Enhancement not backported to 19.11 branch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy(a)bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #28 from Joy Nelson <joy(a)bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24373] New: Correct basic cataloging editor CSS
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 Bug ID: 24373 Summary: Correct basic cataloging editor CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23259 Bug 23259 removed some low-level CSS which negatively affected the appearance of the basic cataloging editor. There shouldn't be green stripes around the tag/subfield tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 [Bug 23259] Remove reset-fonts-grids.css -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 24327] New: anonymous suggestions should not be allowed if AnonymousPatron misconfigured
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Bug ID: 24327 Summary: anonymous suggestions should not be allowed if AnonymousPatron misconfigured Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org If anonymous suggestions (AnonSuggestions) are allowed but AnonymousPatron is not set correctly, it's possible to create a suggestion without being logged in and the app explodes with a FK constraint: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_suggestedby` FOREIGN KEY (`suggestedby`) REFERENCES `bo rrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "INSERT INTO `suggestions` ( `STATUS`, `author`, `branchcode`, `collectiontitle`, `copyrightdate`, `isbn`, `itemtype`, `note`, `pa tronreason`, `place`, `publishercode`, `quantity`, `suggestedby`, `suggesteddate`, `title`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="ASKED", 1="", 2=undef, 3="", 4=undef, 5="" , 6="AUDIOBOOK", 7="", 8="", 9="", 10="", 11=undef, 12="0", 13='2020-01-02T10:28:40', 14="xxx"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Exception::Class::Base::throw('Koha::Exceptions::Object::FKConstraint', 'error', 'Broken FK constraint', 'broken_fk', 'suggestedby') called at /kohadevbox/koha/Koha/Object.pm line 164 -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 --- Comment #4 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Galen Charlton from comment #1) > I suggest a slightly broader way of looking at it. The question isn't so > much whether or not a staff member can change their active library at all, > it's what libraries they're allowed to change to. > > Currently, if IndependentBranches is OFF, a (non-superlibrarian) staff > member is presumed to have their privileges at all libraries. If > IndependentBranches is ON, they're presumed to have their privileges only at > their home library. > > To allow for more fine-grained control, I propose the creation of a new > table that would store the libraries that a given patron has privileges at > (most likely this would apply only to staff users). Initially, that list > could be used to control what library or libraries the staff member can > change to. Another extension, though, would be to use it to control what > libraries are available for various drop-down controls. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Donna <bwsdonna(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna(a)gmail.com --- Comment #3 from Donna <bwsdonna(a)gmail.com> --- This is still a concern for many libraries, would be a great enhancement in the ongoing permissions fine tuning! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15508] Select which library a staff user can login as
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |andrew(a)bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 11420 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '20

31 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #2 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- *** Bug 15508 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0