January 2020 - Koha-bugs - lists.koha-community.org

[Bug 24437] New: Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437 Bug ID: 24437 Summary: Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: nick(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If a library has a circulation rule specific to their library and contains a Hard Due Date and also a circulation rule with a hard due date (set in the past) in the "Standard" set of rules, Koha is calling the standard rule first and then when prompted with a Yellow Box to enter a due date, if hit "Yes", Koha will then call the right rule (library-specific rule). Test: 1. Have a rule set up in a library-specific branch set with Hard Due Before Date in Future 2. Have the same rule set up in the standard set of rules with a Hard Due date set in the past. 3. Check out a book in the library that there is a library-specific rule. 4. Koha will call the standard set of rules, will be unable to assign a due date since it is in the past and present a library with a yellow box to enter a date. 5. If library hits YES without setting a date, Koha will call the due date using the correct (library-specific rules). -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97461|0 |1 is obsolete| | --- Comment #50 from David Nind <david(a)davidnind.com> --- Created attachment 97558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97558&action=ed… Bug 7468: fix the export labels popup header When exporting a barcode range, the export popup should display "1 batch to export" instead of "0 batches to export". In this context, it can be considered a label batch and should be counted as such. To test: When clicking the "Print range" button, the popup should show "1 batch to export". Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97460|0 |1 is obsolete| | --- Comment #49 from David Nind <david(a)davidnind.com> --- Created attachment 97557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97557&action=ed… Bug 7468: (follow-up) Add missing filters Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97459|0 |1 is obsolete| | --- Comment #48 from David Nind <david(a)davidnind.com> --- Created attachment 97556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97556&action=ed… Bug 7468: (follow-up) fix label-edit-range template Edit the labels/label-edit-range.tt template to follow current standards : - Use footer javascript - Use bootstrap grid - Use jQuery Validation plugin for validation Also fixes breadcrumbs to be more specific. To test: Make sure the page looks correct and still works as expected. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97458|0 |1 is obsolete| | --- Comment #47 from David Nind <david(a)davidnind.com> --- Created attachment 97555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97555&action=ed… Bug 7468: (follow-up) Make sure only integers are accepted as from/to values Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97457|0 |1 is obsolete| | --- Comment #46 from David Nind <david(a)davidnind.com> --- Created attachment 97554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97554&action=ed… Bug 7468: Showing the error message according to the community interface patterns, fixing a javascript condition TEST PLAN++ 1) Apply all the patches 2) Connect to the intranet with an account with permissions to visit the "Tools" page 3) Go to /cgi-bin/koha/labels/label-home.pl . Either by entering the URL directly . OR, from the front page, by clicking "Tools", followed by the hyperlink "Label creator" under the "Catalog" section 4) Under the "+ New" button, a new option should be available: "Barcode range" 5) Fill the "From:" and the "To:" fields of the "Print barcode range" form . Keeping both fields at "0" should trigger a warning beside the first field: "*Cannot be smaller than 1" . If the value "From:" is greater the "To:" value, a warning should appear beside the second field: "*Cannot be smaller than the starting value" . Make sure the form doesn't let you enter non-numerical values . For a casual test, use "From: 1000" and "To: 1100" 6) After pressing the "Print Range" button, choose a template, a layout, and a starting position . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of 0pt, don't use it . All the default layouts should look alike, since we're only printing a barcode over a number, and not bibliographic information . Using a layout not defined as 'Barcode' will show a warning message 7) Clicking the "Export" button should lead to a second dialog window with a "Download as PDF" hyperlink. Clicking the link should prop up a download dialog box 8) Save the PDF locally, or simply open it, and make sure the options you used were taken into account Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97456|0 |1 is obsolete| | --- Comment #45 from David Nind <david(a)davidnind.com> --- Created attachment 97553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97553&action=ed… Bug 7468: Add warning when range has non-existent barcodes + Added a warning when the user selects a range with some non-existent barcodes, and a layout without barcodes. This allows the user to print barcodes of items not in the database if he so desires, but will warn him if he tries to print only biblios (which results in missing entries or a blank page). Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97455|0 |1 is obsolete| | --- Comment #44 from David Nind <david(a)davidnind.com> --- Created attachment 97552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97552&action=ed… Bug 7468: Fix 'false' message on Firefox It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97454|0 |1 is obsolete| | --- Comment #43 from David Nind <david(a)davidnind.com> --- Created attachment 97551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97551&action=ed… Bug 7468: Print barcodes by range Adds an option to the label creator to print a range of barcodes. Only allows printing to PDF. C4/Label.pm had to get minor changes to override database-based barcode generation. Same with labels/label-create-pdf.pl. By default, the barcode is fetched from the database using the itemnumber, but when printing ranges, you might not have a corresponding database entry. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '20

17 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0