January 2020 - Koha-bugs - lists.koha-community.org

[Bug 23089] New: Elasticsearch - cannot sort on non-text fields
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Bug ID: 23089 Summary: Elasticsearch - cannot sort on non-text fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com Target Milestone: --- issues is defined as an sum field, this is interpreted to ES as integer, however, the issues__sort field is stored as keyword. Attempting to order search results by 'popularity' fails from ES - because we can't use text fields, we have to use a 'keyword' field. In our biblio search indexes this is fine because our __sort fields all get a phrase keyword field We onyl set field__sort.phrase for text fields though, so issues__sort doesn't use the phrase field, even though it exists Adding a test to try to ilustrate what I am saying here To recreate: 1 - Enable and index ES 2 - Search on staff client or OPAC 3 - Attempt to sort by popularity 4 - It fails, check the error logs to see why -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 41

[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24299 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24298 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24296 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 [Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger` -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24298 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #50 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx a lot for your patience with this one - I feel it works really nicely now! Also passes prove t/db_dependent/Acquisition.t. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95441|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97430&action=ed… Bug 12502: (follow-up) Adds formatting for datatables export Add a format option to the datatables export that remove .noExport elements present in a data cell, just as .noExport columns are not exported. To test: 1. For late orders (which uses .noExport elements in data cells) : Export data in any format using the export button at the top of the datatable. => data should exclude "Add/Edit note" label, but otherwise look the same as before the patch. 2. Try exporting data in other datatables in Koha and make sure exported data is the same before and after applying the patch. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95440|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97429&action=ed… Bug 12502: (QA follow-up) Remove the Save button Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '20

16 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95439|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97428&action=ed… Bug 12502: (follow-up) Use modal to add/edit order notes Replace inputs to edit notes by a link opening a modal, similar to the basket summary page. This makes it possible for the notes to appear in the datatable exports. Also fix exporting with the export as csv button at the bottom of the page to export notes. Test plan : 1) In the late orders table (acqui/lateorders.pl), a link should appear in both the internal and vendor note column, following the current value if it exist. -> This link should read "Add ..." if there is no existing note or "Edit ..." if there is. 2) Click on the link. A modal should appear. Confirm that saving a note works as expected. 3) Try exporting to any format using either the button at the top of the table or the one at the bottom of the page. -> The three new columns and their values should appear in the export. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0