January 2020 - Koha-bugs - lists.koha-community.org

[Bug 17151] New: Extended patron attributes not importing when using double quotes
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17151 Bug ID: 17151 Summary: Extended patron attributes not importing when using double quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: danielle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Patron import tool directions on Patron Import Tool Page states: _____________ Example 2: STARTDATE:January 1 2010,TRACK:Day If an input record has more than one attribute, the fields should either be entered as an unquoted string (previous examples), or with each field wrapped in separate double quotes and delimited by a comma: Example 3: "STARTDATE:January 1, 2010","TRACK:Day" The second syntax would be required if the data might have a comma in it, like a date string. ____________ Only the second example works "STARTDATE:January 1 2010,TRACK:Day" The double quotes import does not work. Loading the patron will fail with a "Line 2 could not be parsed!" error. Partners of BWS are also reporting this same behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Laurence Rault <laurence.rault(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #78 from Laurence Rault <laurence.rault(a)biblibre.com> --- Applied on sandbox CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #47 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #43) > (In reply to Jonathan Druart from comment #42) > > Martin, I think you forgot to add the new dependency. > > C4/Charset.pm:use Unicode::Normalize; > C4/Installer/PerlDependencies.pm: 'Unicode::Normalize' => { > C4/Record.pm:use Unicode::Normalize; # _entity_encode > Koha/Patron.pm:use Unicode::Normalize; > misc/migration_tools/bulkmarcimport.pl:use Unicode::Normalize; > > What did you mean? Indeed, I missed that it was already in our dependency list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97100|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 97175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97175&action=ed… Bug 14759: Add test Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97099|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 97174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97174&action=ed… Bug 14759: Replace Text::Unaccent with Unicode::Normalize As shown in the comments on the bug, it appears that Unicode::Normalize is the most reliable way to strip accents from strings for this use case. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ketan(a)carvingit.com |martin.renvoize@ptfs-europe | |.com QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '20

10 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #42) > Martin, I think you forgot to add the new dependency. C4/Charset.pm:use Unicode::Normalize; C4/Installer/PerlDependencies.pm: 'Unicode::Normalize' => { C4/Record.pm:use Unicode::Normalize; # _entity_encode Koha/Patron.pm:use Unicode::Normalize; misc/migration_tools/bulkmarcimport.pl:use Unicode::Normalize; What did you mean? -- You are receiving this mail because: You are watching all bug changes.

1 0