January 2020 - Koha-bugs - lists.koha-community.org

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Hans Pålsson <hans.palsson(a)hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson(a)hkr.se --- Comment #39 from Hans Pålsson <hans.palsson(a)hkr.se> --- I have applied this patch after having the exact same problem as described in bug 24292. The patch solved the problem and enabled upgrading of the installation from 19.05.04 to 19.05.06. However the patch was applied "manually" editing the code as describes so I can't do a sign-off with a clear conscience. This is un-orthodox but I needed the patch to update a test server, which worked, but I do not have a sandbox or similar to recreate the problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- >From the YAML file: +description: + - "Some basic default authorised values for library locations, item lost status, etc." + - "You can change these at any time after installation." This is what need to be used for translation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #45 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #43) > (In reply to Jonathan Druart from comment #39) > > Bernardo, should not we move it out of the 'en' directory? > > > > I think we should move it to installer/data/mysql/optional, then remove the > > other auth_val.sql files. > > Should not this be done before pushing it? There are translated files for this. Are you suggesting those are moved into .yml? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #44 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #43) > (In reply to Jonathan Druart from comment #39) > > Bernardo, should not we move it out of the 'en' directory? > > > > I think we should move it to installer/data/mysql/optional, then remove the > > other auth_val.sql files. > > Should not this be done before pushing it? - Installer works as expected and strings are shown as before - QA script is happy ¡Excelente trabajo Pichu, para variar! Feliz 2020!! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #39) > Bernardo, should not we move it out of the 'en' directory? > > I think we should move it to installer/data/mysql/optional, then remove the > other auth_val.sql files. Should not this be done before pushing it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #42 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 97069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97069&action=ed… Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #41 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 97068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97068&action=ed… Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '20

09 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0