October 2020 - Koha-bugs - lists.koha-community.org

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Barbara Johnson <barbara.johnson(a)bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson(a)bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #9 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 111440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111440&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #8 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 111439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111439&action=e… Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #7 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 111438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111438&action=e… Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #6 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 111437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111437&action=e… Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '20

10 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano <agustinmoyano(a)theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25244] New: Accessibility: Checkboxes on the search results page do not contain specific aria labels
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '20

09 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Bug ID: 25244 Summary: Accessibility: Checkboxes on the search results page do not contain specific aria labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: oleonard(a)myacpl.org, testopia(a)bugs.koha-community.org Depends on: 25243 Blocks: 23003 Multiple generic ‘Select this item’ check boxes are present on the search results pages that some users may not be able to differentiate between when navigating out of context. 1/ Search for an item 2/ Note that the results page has multiple checkboxes with matching aria tags. Current code: <td class="select selectcol"> <input name="biblionumber" class="cb" id="bib28526" aria-label="Select this item" type="checkbox" value="28526"> <label for="bib28526"></label> </td> Solution: Ensure that all form elements are uniquely descriptive of their purpose. For example: <td class="select selectcol"> <input name="biblionumber" class="cb" id="bib28526" aria-label="Select ‘Taxing time for housing’" type="checkbox" value="28526"> <label for="bib28526"></label> </td> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25243 [Bug 25243] Accessibility: 2.4.6 Headings and Labels -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 26652] New: Add a way to mark messages as 'seen' in Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '20

09 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652 Bug ID: 26652 Summary: Add a way to mark messages as 'seen' in Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 26555 adds a way for Koha::Object-derived classes to carry errors messages between method calls. On bug 26651 there's a proposal for a Koha::Object->reset_messages method that *could* be used to clean that messages list, if required. Another option could be to have Koha::Object::Message carry some flag (seen?) that tells if the message has already been looked at. So if ->messages is called twice, the second one returns no results as all messages have been marked as seen: =head3 messages $object->methods ->that ->each ->adds ->messages; @messages = $object->messages; # all accumulated messages @messages = $object->messages; # @messages is empty $object->boo; @messages = $object->messages; # @messages contains messages added by ->boo The implementation could look like: =cut sub messages { my ($self) = @_; my @messages = map { $_->mark_as_seen } @{ grep { $_->unseen } @{ $self->messages } }; return \@messages; } package Koha::Object::Message; sub mark_as_seen { my ($self) = @_; $self->{seen} = 1; return $self; } A method for retrieving all messages in the object lifetime could be added. I put this here for discussing it, and just in case someone is looking for something like this and finds this bug, adding their two cents here with their use cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26563] New: Merging patrons will cause the "time queued" column in the message queue to be updated to the current date and time
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '20

09 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26563 Bug ID: 26563 Summary: Merging patrons will cause the "time queued" column in the message queue to be updated to the current date and time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The column time_queued is considered by librarians to be either the time a message was created ( if pending ), or the time a message was sent. Merging patrons will cause this column to be updated, making it look like the message was sent far more recently. It might be worth considering adding a new column for datetime_created, and datetime_sent, while leaving the existing column alone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '20

09 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #52 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 111410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111410&action=e… Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item <ItemBarcode> -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron <PatronABarcode> --item <ItemBarcode> -m checkout Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0