October 2020 - Koha-bugs - lists.koha-community.org

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Should this really be marked as Major btw ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Works, but kind of tweaky ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 111065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111065&action=e… Bug 7607: (QA follow-up) Add comment line to new submit action The solution here is a workaround, but we need to document why we are doing this. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110849|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 111064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111064&action=e… Bug 7607: Fix adv search when leaving fields empty We have a rewrite rule in our apache config that remove empty parameters: RewriteCond %{QUERY_STRING} (.*?)(?:[A-Za-z0-9_-]+)=&(.*) That causes the advanced search to search on the wrong index if an input field is left empty. Test plan (staff and OPAC): - leave the first pulldown on keyword and the search term empty - select author or title from the second pull down and enter a search term Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #124 from Maryse Simard <maryse.simard(a)inlibro.com> --- It has been said a few times before that this would have been better splitted into different bugs. I agree with that and feel that now is a good time to do so, considering the changes which have to be done anyway because of the new PrefillGuaranteeField preference. Therefore this patch has been splitted into 3 different bugs. This one has been renamed to "Ability to allow guarantor relationship for all patron category types", as proposed, to better reflect what it does. 1) I wasn't aware of the new PrefillGuaranteeField preference, but it does indeed replace GuarantorFields. However, this patch also introduced a new use of the preference to transfer informations from guarantor to guarantee not only when creating a new guarantee, but also when adding a new guarantor relationship to an existing patron. This part of the patch has been moved to a new bug (Bug 26597). > Hm another question: can you explain the changes to the various > patron/member search related files? The changes to search files are for this part of the patch. 4) I've decided to make a few changes to the way the fines are displayed, following the advice mentionned here. However, since I was splitting this already, I've moved these corrections to a new bug (Bug 26598). Finally, since this is a big change in the content of the bug, I merged all patches and set it back to need signoff. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #123 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 111053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111053&action=e… Bug 12446: Schema update Category.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '20

02 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106753|0 |1 is obsolete| | Attachment #106754|0 |1 is obsolete| | Attachment #106755|0 |1 is obsolete| | Attachment #106756|0 |1 is obsolete| | Attachment #106757|0 |1 is obsolete| | --- Comment #122 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 111052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111052&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass -- You are receiving this mail because: You are watching all bug changes.

1 0