November 2020 - Koha-bugs - lists.koha-community.org

[Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 --- Comment #85 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #84) > The dump and restore approach is bad and will break the tests if ran in > parallel (what we are supposed to support). However it seems that jenkins > has nodes returning 1 to nproc as they are not failing (that much). Under MySQL 8: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/www/regressions.t t/db_dependent/www/regressions.t .. mysqldump: Error: 'Access denied; you need (at least one of) the PROCESS privilege(s) for this operation' when trying to dump tablespaces Can we now deal with that please? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #10 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Can't we add this in all pages via opac-bottom.inc ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 26162] New: Prevent Selenium's StaleElementReferenceException
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162 Bug ID: 26162 Summary: Prevent Selenium's StaleElementReferenceException Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Got something new on Master_U18 #862 after bug 26143. 18:47:07 selenium_1 | 09:47:07.478 WARN - Exception: Element not found in the cache - perhaps the page has changed since it was looked up 18:47:07 selenium_1 | For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html 18:47:07 selenium_1 | Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03' 18:47:07 selenium_1 | System info: host: '78b9a07f51f2', ip: '192.168.16.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.19.0-9-amd64', java.version: '1.8.0_91' 18:47:07 selenium_1 | Driver info: driver.version: unknown 18:47:07 koha_1 | 18:47:07 koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 18:47:07 koha_1 | /usr/local/share/perl/5.26.1/Selenium/Remote/Driver.pm:353 in Try::Tiny::try 18:47:07 koha_1 | (eval 1571):1 in Selenium::Remote::Driver::__ANON__ 18:47:07 koha_1 | (eval 1573):2 in Selenium::Remote::Driver::__ANON__ 18:47:07 koha_1 | (eval 1546):17 in Selenium::Remote::Driver::_execute_command 18:47:07 koha_1 | /usr/local/share/perl/5.26.1/Selenium/Remote/WebElement.pm:63 in Selenium::Remote::WebElement::_execute_command 18:47:07 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:184 in Selenium::Remote::WebElement::click 18:47:07 koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:172 in t::lib::Selenium::click_when_visible 18:47:07 koha_1 | t/db_dependent/selenium/administration_tasks.t:131 in t::lib::Selenium::click It's failing consistently on D11 locally. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- (In reply to Katrin Fischer from comment #8) > I am a bit confused by the changes to history.txt in this patch set, can > someone explain? Same for me. Forms double submit protection seems really usefull BTW. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10943] Impossible to manage fines without borrowers permission
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #19 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- I set to in discussion because all pages about patron accounting need permission "edit_borrowers". So we should reconsider dropping it in pay.pl. See : $ git grep -B1 updatecharges members/ members/accountline-details.pl- borrowers => 'edit_borrowers', members/accountline-details.pl: updatecharges => 'remaining_permissions' -- members/boraccount.pl- flagsrequired => { borrowers => 'edit_borrowers', members/boraccount.pl: updatecharges => 'remaining_permissions'}, -- members/mancredit.pl- borrowers => 'edit_borrowers', members/mancredit.pl: updatecharges => 'remaining_permissions' -- members/maninvoice.pl- borrowers => 'edit_borrowers', members/maninvoice.pl: updatecharges => 'remaining_permissions' -- members/pay.pl- members/pay.pl:my $updatecharges_permissions = $input->param('woall') ? 'writeoff' : 'remaining_permissions'; -- members/pay.pl- type => 'intranet', members/pay.pl: flagsrequired => { borrowers => 'edit_borrowers', updatecharges => $updatecharges_permissions }, -- members/paycollect.pl- members/paycollect.pl:my $updatecharges_permissions = ($writeoff_individual || $type eq 'WRITEOFF') ? 'writeoff' : 'remaining_permissions'; -- members/paycollect.pl- type => 'intranet', members/paycollect.pl: flagsrequired => { borrowers => 'edit_borrowers', updatecharges => $updatecharges_permissions }, -- members/printfeercpt.pl- type => "intranet", members/printfeercpt.pl: flagsrequired => {borrowers => 'edit_borrowers', updatecharges => 'remaining_permissions'}, -- members/printinvoice.pl- type => "intranet", members/printinvoice.pl: flagsrequired => { borrowers => 'edit_borrowers', updatecharges => 'remaining_permissions' }, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10943] Impossible to manage fines without borrowers permission
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #18 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Bug 18403 changed borrowers => 1 to borrowers => 'edit_borrowers' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10943] Impossible to manage fines without borrowers permission
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35355|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10943] Impossible to manage fines without borrowers permission
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #17 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- >From comments I understand that first patch " [SIGNED OFF] Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines." is obsolete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10943] Impossible to manage fines without borrowers permission
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- There is a typo in message : Bug 10943: Manage files without borrowers permission "files" is "fines" ^^ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13146] Improve GetRecordValue function by caching field mapping
by bugzilla-daemon＠bugs.koha-community.org 10 Nov '20

10 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #10 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- I set invalid since Bug 11529 removed method C4::Biblio::GetRecordValue : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91834 -- You are receiving this mail because: You are watching all bug changes.

1 0