December 2020 - Koha-bugs - lists.koha-community.org

[Bug 13911] Add support for Internet Archive BookReader
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper <rkuiper(a)roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rkuiper(a)roundrocktexas.gov | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13911] Add support for Internet Archive BookReader
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper <rkuiper(a)roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper(a)roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13326] Add possibilty to edit purchase suggestion on opac
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Rhonda Kuiper <rkuiper(a)roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper(a)roundrocktexas.gov --- Comment #4 from Rhonda Kuiper <rkuiper(a)roundrocktexas.gov> --- We have found the ability for patron to delete items even after the item has been ordered a problem especially with the functionality in 20.05 that limits the number of patron suggestion within a specified time period. (MAXTOTALSUGGESTION and NUMBEROFSUGGESTIONDAYS). With this function, if the patron deletes a suggestion after it is no longer in pending status, the NUMBEROFSUGGESTIONDAYS calculation isn't accurate. We ended up removing the Delete function on the OPAC with some jquery. The solution I would suggest is two fold: -If the suggestion is in pending status, they can delete it (or edit as suggested earlier). Rationale: The library staff has not spent any time dealing with the suggestion so there is no time lost or confusion about what the person wants. -If the suggestion in any status other that pending, they can delete it from the OPAC display but what is really happening is the suggestion is archived (using the function from bug 22784). What would display on the OPAC is all non-archived suggestions. This way the suggestion stays in the database and the NUMBEROFSUGGESTIONDAYS calculation will still be accurate along with any other stats a library would like to gather. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 20150] New: Acquisitions wizard always uses listprice
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Bug ID: 20150 Summary: Acquisitions wizard always uses listprice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When using the acquisitions wizard, you can choose between different options: - Amount: - Ordered amount: - Spent amount: The calculations are always done with listprice. Especially for the amount spent this makes the wizard not match up with the amounts on the acquisition homepage as the actual amount spent can be quite different from the list price used when ordering. I think it probably should be calculated like this: - Amount: list price of ordered items + actual price of received items - Ordered amount: list price - Spent amount: actual price -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 27073] New: refactor cover image to get image(s) (url) from api call/template include
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27073 Bug ID: 27073 Summary: refactor cover image to get image(s) (url) from api call/template include Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: koha(a)trust-box.at QA Contact: testopia(a)bugs.koha-community.org it seems for me that there is (template) code duplication to show cover images. see grep -rl OPACAmazonCoverImages includes/shelfbrowser.inc includes/opac-bottom.inc modules/opac-user.tt modules/opac-opensearch.tt modules/opac-results-grouped.tt modules/opac-readingrecord.tt modules/opac-detail.tt modules/opac-shelves.tt modules/opac-showreviews-rss.tt modules/opac-showreviews.tt modules/opac-results.tt I'm not sure if this is autogenerated? maybe this duplicate code should be wrapped in an api call, with more logic implemented than in the rather crude template if-statments -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #30) > I've made some starting changes to the notices to use Koha::Biblio objects > mostly (you can see it in the atomic update in the patch). > > I need some guidance/help with a few things: > - I wasn't sure where to get the dewey and classification info from It looks like they are always empty. It's broken since the following commit: commit af466ca41ab02150f4f6c60bf6262b079b2e6e85 Date: Thu Oct 18 18:53:52 2007 -0500 start of reworking call number handling and other Biblio changes IMO we should not reintroduce them on this bug report. > - I wasn't sure which notes field to use (biblioitems or biblio) It's coming GetBiblioData 729 my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan as bi_notforloan, biblio.notes So it's the 'notes' from biblio. > - the Author and Subjects subroutines are the hardest for me to refactor > because I'm not sure how different libraries use them Hum... Another weirdness. On opac-sendshelf: MARCSUBJCTS is set but not used in the template, 'subject' is used instead, but never sent from the pl... and it's the same for the other ones (sendbasket, sendshelf both OPAC and staff interfaces). I'd drop it as well. For MARCAUTHORS I'd try and write the equivalent of C4::Biblio::GetMarcAuthors in TT, and see how it goes (10 lines or 30 lines?). If it's too ugly then move to Koha::Biblio->get_MARC_authors (or get_authors_from_MARC?) > Some feedback would be great! Don't forget that you are in a quite dirty place. Don't loose time with things that are not working, drop them. I'd suggest that you focus on the simplest template first, no need to work in parallel on the four ones. Additional note, in your patch you are not looping at all on a Koha::Biblio set. As it's a WIP maybe you are aware of it, but I prefer to highlight it in case you missed it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18789] New: Send a Koha::Patron object to the templates
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Bug ID: 18789 Summary: Send a Koha::Patron object to the templates Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18403 The simplify and make uniform the code, the controller scripts should send a Koha::Patron object to the templates and not all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.

1 112

[Bug 14564] Incorrect permissions prevent web download of configuration backups
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14564] Incorrect permissions prevent web download of configuration backups
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0