December 2020 - Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '20

17 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Hello Aleisha, This is a very interesting part to move to the notice templates! However I am expecting it to be tricky, as you saw already :) Before starting to implement anything I would suggest you to come with a plan. I can provide you early feedback to see if we are starting with the best solution. In my opinion we should only pass Koha::Objects-based variables to the template. Reusing the existing variables will make us start with obsolete code (it will be harder to improve it in the future as the libraries will have this TT code in their templates). (In reply to Katrin Fischer from comment #11) > Could we imagine replacing the old subroutines by a more generic approach of > accessing the information in the MARC record instead of moving them? > > Thinking of something like: > > [% record.245a %] Says we are talking about GetMarcUrls, it could be something like: [% SET marc_record = biblio.metadata.record %] [% FOR f IN marc_record.field('856') %] [%# Then do something for every 856 field [% END %] But then you are going to rewrite the code that is in a subroutine to a TT syntax, that will be copy/pasted in different places. And it's not what we want, it's too error prone (no test coverage, dup of code). The only long term and viable solution is to move them to the Koha namespace. Have the Get* subroutines moved to Koha::Biblio methods, have the test coverage, replace the existing occurrences, and finally reuse them from the template notices. But this task is huge... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '20

17 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Could we imagine replacing the old subroutines by a more generic approach of accessing the information in the MARC record instead of moving them? Thinking of something like: [% record.245a %] We can actually do something similar in CSV profiles, but it appears sadly undocumented in the manual: Bug 12404 (the help file with the documentation was removed, but some examples in the comment of the bug) I think if we don't match the current output 100% that would actually be a good thing as the old routines sometimes display subfields that you don't really want to see in the notices, and it's all hard coded and not nice to use or change or format. So we will likely have more issues to deal with later on always coming back to these methods. And it could be really useful for other notices as well (later). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...)
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '20

17 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Appears sadly to be undocumented! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '20

17 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #10 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- I'm currently working on this, and a big goal is to make it work as a notice with the template toolkit syntax. I believe this depends on moving some of the old C4/Biblio.pm subroutines (GetMarcAuthors etc) into Koha/Biblio.pm. That work would be substantial and needs to be done first, in separate bugs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27079] New: UpdateFine adds refunds for fines paid off before return
by bugzilla-daemon＠bugs.koha-community.org 17 Dec '20

17 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Bug ID: 27079 Summary: UpdateFine adds refunds for fines paid off before return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The issue seems to be that the amount passed in to UpdateFine fails the comparison to $accountline->amount - one is $1.80 and the other is $1.80000 and comparison fails: 576 if ( $accountline ) { 577 if ( $accountline->amount != $amount ) { To recreate: 1 - Set a circ rule to have a .15 per day fine 2 - Issue an item of this type to a borrower 3 - Make it 12 days overdue either at checkout or in the db: UPDATE issues SET date_due = DATE_SUB(CURDATE(),INTERVAL 12 DAY); 4 - Run the fines job or just put a fine in place: INSERT INTO accountlines (issue_id,borrowernumber,itemnumber,amount,debit_type_code,status,amountoutstanding) SELECT issue_id,5,itemnumber,1.80,'OVERDUE','UNRETURNED',1.80 FROM issues WHERE borrowernumber=5; 5 - Pay the fine for the patron 6 - Check in the item 7 - Note that the patron has an 'Overpayment refund' of $0.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32

[Bug 27092] New: Remove note about "synced mirror" from the README.md
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '20

16 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 Bug ID: 27092 Summary: Remove note about "synced mirror" from the README.md Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Now it's displayed on our git.k-c.org by gitea, we should remove **Note:** This is a synced mirror of the official Koha repo. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 8948] MARC21 field 787 doesn't display
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '20

16 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 HeinrichJBHeidenreich(a)gmx.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |HeinrichJBHeidenreich(a)gmx.d | |e Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23294] New: standing order not showing actual cost when modifying order
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '20

16 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Bug ID: 23294 Summary: standing order not showing actual cost when modifying order Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Bug 23020 already details how received cost for standing orders is not shown on basket.pl. 18.11 has changed how costs are calculated and displayed on neworderempty.pl, exacerbating the problem To Test: - Create a standing order basket - Add an order to that basket with no price information filled out - Receive a copy of the standing order and record an actual price at receipt - Go back to your basket and click Modify for your received order - See that it still shows $0 for Total Prior to 18.11, Total was derived from aqorders.unitprice, which reflected the Actual Cost entered when receiving. Now it is only derived from budgeted cost. This is an issue for standing orders, for which many libraries do not enter a budgeted cost, only an actual cost at receipt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 23966] New: Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '20

16 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bug ID: 23966 Summary: Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 16 Dec '20

16 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] Add button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes.

1 0