December 2020 - Koha-bugs - lists.koha-community.org

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #66 from David Cook <dcook(a)prosentient.com.au> --- To run the unit tests: root@kohadevbox:koha(bug_12430)$ prove t/Search/buildQuery.t t/Search/buildQuery.t .. ok All tests successful. Files=1, Tests=10, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.87 cusr 0.15 csys = 3.06 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99158|0 |1 is obsolete| | --- Comment #65 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114130&action=e… Unit tests for buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99141|0 |1 is obsolete| | --- Comment #64 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114129&action=e… Bug 12430: Force relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 0) Use koha-testing-docker 1) Ensure that "QueryWeightFields" is enabled and "QueryAutoTruncate" is set to auto 2) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 3) Note that the results are ordered by biblionumber ascending 4) Apply patch 5) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 6) Note that the results are not ordered by biblionumber ascending (presumably they are in relevance order) If you edit /etc/koha/sites/kohadev/koha-conf.xml and add "requests" to the end of "zebra_loglevels", uncomment that option, and carefully restart Zebra, you should be able to see the following in /var/log/koha/kohadev/zebra-output.log: Search biblios OK 394 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 @attr 2=102 e The 2=102 indicates a relevance search. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #63 from David Cook <dcook(a)prosentient.com.au> --- Changing the 2nd patch to use t/Search/buildQuery.t instead of t/Search.t because it's so complex it deserves to be in its own file... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #62 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Nind from comment #51) > Everything works as per the the test plan, but tests fail: > > Test Summary Report > ------------------- > t/Search.t (Wstat: 256 Tests: 6 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > Files=1, Tests=6, 4 wallclock secs ( 0.03 usr 0.01 sys + 3.42 cusr 0.12 > csys = 3.58 CPU) > Result: FAIL It looks like the first patch is good, but my "Unit tests for buildQuery" patch is not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #61 from David Cook <dcook(a)prosentient.com.au> --- root@kohadevbox:koha(master)$ git checkout bug12430 Switched to branch 'bug12430' Your branch and 'origin/master' have diverged, and have 1 and 19114 different commits each, respectively. (use "git pull" to merge the remote branch into yours) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #9 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 114127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114127&action=e… Bug 3150: WIP This is not ready yet! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27088] New: Searching with just OR or AND gives error
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 Bug ID: 27088 Summary: Searching with just OR or AND gives error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi If you search in intranet with elasticsearch just the string > OR or > AND Then Koha gives error: > Error: Unable to perform your search. Please try again. What I was expecting: no results found. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 11529] Add subtitle, medium and part fields to biblio table
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 [Bug 27137] Move item doesn't show the title of the target record -- You are receiving this mail because: You are watching all bug changes.

1 0