February 2020 - Koha-bugs - lists.koha-community.org

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #58 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Great work Bernardo, thanks for your efforts here.. All looking good and working as expected for me.. Signing off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98741|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99395&action=ed… Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98507|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99394&action=ed… Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97069|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99393&action=ed… Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97068|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99392&action=ed… Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11161] Relabel 'child fund' to 'sub fund'
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 --- Comment #7 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11161] Relabel 'child fund' to 'sub fund'
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9989] Closing a basket without creating a basketgroup should not redirect to baskets list
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9989 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4) > There is 2 places now where one can close the basket: > - From the basket summary page. I totally agree with the new redirect there. > - From the vendor search results list - This one I am not sure about. I > think the old redirect works better there as it would allow you to quickly > close multiple baskets. > > Jessica, as you signed off, what do you think? I agree with that. Failing QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Owen, sorry but I found a regression. With OPACPopupAuthorsSearch and NOT OPACXSLTDetailsDisplay Hit /cgi-bin/koha/opac-detail.pl?biblionumber=15 Without the patch, the link on "Additional authors: Bradbury, Nicola." opens a popup. It does not with your patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #25) > Sorry, working on the older bugs by bug number - missed your QA contact > (also sometimes it's not reliable :) ) No worries I was not, I assigned to me after you PQAed it! :) -- You are receiving this mail because: You are watching all bug changes.

1 0