March 2020 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96090|0 |1 is obsolete| | --- Comment #125 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101571&action=e… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96089|0 |1 is obsolete| | --- Comment #124 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101570&action=e… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96088|0 |1 is obsolete| | --- Comment #123 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101569&action=e… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96087|0 |1 is obsolete| | --- Comment #122 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101568&action=e… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96086|0 |1 is obsolete| | --- Comment #121 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101567&action=e… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96085|0 |1 is obsolete| | --- Comment #120 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101566&action=e… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96084|0 |1 is obsolete| | Attachment #96096|0 |1 is obsolete| | --- Comment #119 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 101565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101565&action=e… Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24528] New: Add a syntax for specifying counts on x-koha-embed
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 Bug ID: 24528 Summary: Add a syntax for specifying counts on x-koha-embed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com We need a way to specify that we want the count of the relation result and not the result itself, this way we don't need to implement *_count methods (see bug 24467) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #48 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 101547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101547&action=e… Bug 13881: (QA follow-up) Some documentation and terminology fixes - Branchcode = Library - Desk id = Desk ID - Show library name on desk list and when deleting desk instead of code - Some small changes to the database documentation. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13881] Add desk management
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '20

24 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #47 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 101546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101546&action=e… Bug 13881: (QA follow-up) Check for manage_libraries permission The .pl was checking for a new permission desks_management not (yet) added. As the templates already checked for manage_libraries the .pl was changed accordingly to also use it. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0