March 2020 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100498|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100520&action=e… Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100497|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100519&action=e… Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100496|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100518&action=e… Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100495|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100517&action=e… Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100494|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100516&action=e… Bug 4461: Better error handling Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100493|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100515&action=e… Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100492|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100514&action=e… Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100491|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100513&action=e… Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100490|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100512&action=e… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '20

11 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100489|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 100511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100511&action=e… Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0