March 2020 - Koha-bugs - lists.koha-community.org

[Bug 10269] add a way to define a specific replyto email address for some notice
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22821 Depends on|22821 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 [Bug 22821] Patron notes about item email notification fallback order is incorrect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #48 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I documented some of the ReplyTo stuff back when it was first introduced as a feature in bug 9530.. Jonathan is correct, we should not spoof user address in the from address is it's very likely you'll end up in a spam list that way. https://wiki.koha-community.org/wiki/MRenvoize/Email roughly explains it and I have a feeling that was lifted and put in our own manual somewhere but I can't see it right now. In bug 22821 I add some handling to allow specifying reply-to address at the EnqueuLetter stage.. it is my feeling if you want to send email 'from' a patron 'to' a library you should use a combination of not supplying a 'from' address (as it'll pick an appropriate one in _send_message_by_email), setting the 'to' using Koha::Library->get_effective_email (perhaps I should rename that get_inbound_email_address) which will do an appropriate fallback through replyto addresses and finally add a reply-to address of the patron so whoever receives the email can reply to the actual user. See bug 22821 and bug 22823 for some further details around email handling. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #47 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- If Aleisha says the GUI will be next, I am not so worried about the status and such. It would be nice to see the code, but I feel this was just planning ahead and would not cause harm for now. > > In this case I think we could set it as: > > $patron->notice_email_address || $koha_admin; > > I do not think so, as said in the commit message "I do not think it's a good > idea, we should not send an email with "from" if not really sent by the > user." I think it's bad practice to do that, I may be wrong however. I agree here. To avoid being rejected as spam you can use the reporting patron's email as replyto, but not as From. So it's more than a bad practice as a lot of mail servers got a lot stricter in the last years - it will be real trouble (been there). From and Return-path needs to be from the mail servers domain. See also: https://wiki.koha-community.org/wiki/MRenvoize/Email -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3679] Specify Reply-To address when emailing a list or cart from OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3679 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22821 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 [Bug 22821] Patron notes about item email notification fallback order is incorrect -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2234] Make cart email from/reply-to/return-path address configurable
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |22821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 [Bug 22821] Patron notes about item email notification fallback order is incorrect -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10269] add a way to define a specific replyto email address for some notice
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |22821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821 [Bug 22821] Patron notes about item email notification fallback order is incorrect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #45) > (In reply to Jonathan Druart from comment #44) > > What do others think? Could we get your opinions? > > I think having option to get email notices as well as having the staff > interface is useful - I don't think we need to pick only one - but once > there is a GUI the notices should be optional The problem with having the GUI after is that we do not deal with some of the already created fields. See comment 42: "the status will never be updated, what will happen when we will have the UI?" > >Bug 4461: Use KohaAdminEmailAddress pref as 'from' > I don't understand that followup - 'from_address' is just picked form the > message in C4/Letters - it is 'to_address' that usually gets filled at send > - to be to the borrowernumber > > In this case I think we could set it as: > $patron->notice_email_address || $koha_admin; I do not think so, as said in the commit message "I do not think it's a good idea, we should not send an email with "from" if not really sent by the user." I think it's bad practice to do that, I may be wrong however. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775 [Bug 24775] Payment submit button on POS page should have an ID -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 [Bug 24479] New POS doesn't follow CurrencyFormat -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15377] Allow removal of 'checked out' items from course reserves
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

1 0