May 2020 - Koha-bugs - lists.koha-community.org

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #22 from Rudolf Byker <rudolfbyker(a)gmail.com> --- (In reply to David Cook from comment #20) > (In reply to Martin Renvoize from comment #16) > > > > I am, however, pretty keen to take such an approach and drop 5.5 support > > with this release and so this patch is 'on hold' for now. > > For what it's worth, I think koha-remove uses "DROP USER IF EXISTS", so we > already have mixed support for 5.5. > > I ended up removing "IF EXISTS" and updating koha-remove to use --force so > that it could survive fatal errors. Are you talking about the `--force` option on the MySQL command line utility? That smells like technical debt. Using it is the same or worse as using `|| true`, since you will hide lots of potential errors. We only need to handle one very specific error (which is not even an error, if you consider Idempotency to be a good programming pattern for such scripts – which it is). Using a catch-all to hide all errors is almost always a Bad Idea (TM). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #21 from Rudolf Byker <rudolfbyker(a)gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #18) > > 2) Remove the instance completely using `koha-remove`. > > I'm having an issue here. Maybe it's my dev environment. > > root@4dfd0fcc251b:kohadevbox$ koha-remove kohadev > Removing Koha instance kohadev > [ ok ] Stopping Plack daemon for kohadev:. > userdel: user kohadev-koha is currently used by process 1005 > /usr/sbin/deluser: `/usr/sbin/userdel kohadev-koha' returned error code 8. > Exiting. > > > > > Using koha-disable doesn't help. There are still starman and apache > processes running that are from the unix user of the instance. > > Could there be anything more to do before removing the instance? Probably your dev environment. I've never had this issue, and I'm using my own patch. Did you check which process is still using the user using `ps -u kohadev-koha`? By the way: Is the test plan supposed to be in the commit message, in a comment, or both? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- https://wiki.koha-community.org/wiki/Holdings_data_fields_(9xx) likely needs updating to reflect this bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- With those two followups adding tests and improving the POD I think we can safely PQA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 104403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104403&action=e… Bug 13547: (QA follow-up) Add basic tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12017] Move language description out of database
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25376 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 104402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104402&action=e… Bug 13547: (follow-up) Improve POD for template plugin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25364 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
by bugzilla-daemon＠bugs.koha-community.org 06 May '20

06 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #20 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Martin Renvoize from comment #16) > > I am, however, pretty keen to take such an approach and drop 5.5 support > with this release and so this patch is 'on hold' for now. For what it's worth, I think koha-remove uses "DROP USER IF EXISTS", so we already have mixed support for 5.5. I ended up removing "IF EXISTS" and updating koha-remove to use --force so that it could survive fatal errors. -- You are receiving this mail because: You are watching all bug changes.

1 0