June 2020 - Koha-bugs - lists.koha-community.org

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 [Bug 25723] Drop DateTime::Set as a dependancy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I think this is still somewhat of an issue.. in my experience we've now worked through the IO bound performance issue with the caching bugs, but we still have some CPU bound issues relating to the slow instantiation speed of DateTime. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #304 from Michal Denar <black23(a)gmail.com> --- Hi, I could participate on documetation. But I'm not developer, I need some "how to" from David or Tomás, how integrate translation into code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen <emmi.takkinen(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |emmi.takkinen(a)outlook.com |ity.org | Status|Failed QA |Needs Signoff --- Comment #35 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 105777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105777&action=e… Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen <emmi.takkinen(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87531|0 |1 is obsolete| | CC| |emmi.takkinen(a)outlook.com --- Comment #34 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 105776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105776&action=e… Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #303 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Magnus Enger from comment #301) > (In reply to David Cook from comment #299) > > Looks like Tomas has already added translations to a plugin > > (https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/tree/ > > master/Koha/Plugin/Com/Theke/PayViaPayPal), so I'll model my work on that. > > Bonus points to the person who documents how it's done, for example on the > wiki! :-) I'm only one man... 😭 But noted heh. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #302 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Michal Denar from comment #300) > Hi David, > yes, I saw this solution. JSON file is easy to edit, I like it. Oh, it's not a JSON file. It'll be Template::Toolkit template files. Still very easy. Examples: https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/blob… https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/blob… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25608] New: Regression: Bug 23463 broke inventory
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Bug ID: 25608 Summary: Regression: Bug 23463 broke inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: didier.gautheron(a)biblibre.com Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 23463 need to use unblessed items. Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Check ' - Submit => without patch, you get an error trace Error trace Can't call method "title" on an undefined value at /kohadevbox/koha/tools/inventory.pl line 347, <$fh> line 2. at /kohadevbox/koha/tools/inventory.pl line 347 in (eval) at /kohadevbox/koha/tools/inventory.pl line 347 344: : $inventorylist // []; 345: for my $item ( @$loop ) { 346: my $biblio = Koha::Biblios->find( $item->{biblionumber} ); 347: $item->{title} = $biblio->title; 348: $item->{author} = $biblio->author; 349: } 350: Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 25556] New: Holds blocked when empty holdallowed value present in circulation_rules
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556 Bug ID: 25556 Summary: Holds blocked when empty holdallowed value present in circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: stalkernoid(a)gmail.com Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, slavashishkin(a)gmail.com Holds blocked ("Cannot place hold" yellow notification window) for default rule after onboarding.pl (web installation process). That happens because /cgi-bin/koha/installer/onboarding.pl script creates the empty (holdallowed="") key/value pair in the circulation_rules table. Probably empty ("") holdallowed key assumed to have the same behavior as undef/NULL, because: - in the interface (/cgi-bin/koha/admin/smart-rules.pl) both are interpreted as "Not set" (undef or ""), - if to remove this empty value for holdallowed from circulation_rules table at all (so have it undef) holds allowed and not blocked. - in other cases if "holdallowed" has correct values from the dropdown list (0, 1, 2, 3) - all works as expected. I.e.: 1. ="" has behavior as ="0", 2. value absence (NULL/undef) has behavior as ="2" ("from any library"). 3. but for both values site interface shows "not set". This makes confusion: in 1. it blocks holds, and in 2. it allows. I propose we make both "" and undef work similarly as "not set" in "check if holds allowed" code, and both to allow holds like undef now does. And at the same time remove "" creation but use undef instead in the onboarding process when done first rule creation. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 25428] New: Escaped HTML shows in authority detail view when subfield is a link
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '20

12 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428 Bug ID: 25428 Summary: Escaped HTML shows in authority detail view when subfield is a link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 104604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104604&action=e… Screenshot showing the problem In authority records there is the option to designate a subfield as a URL (like we do for 856$u in the default MARC framework). When you view the details of such a record the URL is output to the screen as HTML markup. This is because the script is sending hard-coded HTML to the template and the template outputs is as escaped. Rather than use the $raw filter to make the link work, we should remove the script-generated HTML and do it in the template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11