July 2020 - Koha-bugs - lists.koha-community.org

[Bug 25967] New: Plugin upgrade should remove existing code before installing new code
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25967 Bug ID: 25967 Summary: Plugin upgrade should remove existing code before installing new code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, upgrading a plugin really means overwriting the existing plugin files with new files. This is fine for files that are added or modified, but it won't remove files that have been deleted. Of course, we don't necessarily know what files to delete when we're upgrading a plugin, because we don't track the files, and the files can be a bit messy. For instance, "/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions" is the root for both KitchenSink and CoverFlow. This is probably an infeasible idea due to existing installs, but just pointing out the flaw in the plugin architecture. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106721&action=e… Bug 25723: (QA follow-up) Silent POD warning I didn't introduce the method that is warned about, but adding POD for it seemed reasonable and will silence the QA Script warning. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106720&action=e… Bug 25723: Remove tests for removed method We removed the exception_holidays (and single_holidays) methods as part of this patchset. As such, we should no longer test them ;) Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106719&action=e… Bug 25723: Update cache flushing calls This patch updates the previous single_holidays and exeption_holidays cache flushing calls to match the new cache key structure of the updated routines. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106718&action=e… Bug 25723: Use the same code for single and exception holidays This patch refactors is_exception_holiday and is_single_holiday to utilise a single _holidays method which combines the logic of the previous single_holidays and exception_holidays methods. As Koha::Calendar is instantiated at a branch level, we also move split the cache into branches too. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106717&action=e… Bug 25723: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106716&action=e… Bug 25723: Drop DateTime::Set from cpanfile Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #15 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106715&action=e… Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106714&action=e… Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #19 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Joe Sikowitz from comment #18) > Hi Nick, > > These patches keep things simple and work as expected. > > Blocker: > 1 - If I enter barcodes that are not in any courses I report successful > deletion from all courses - I don't think that's right > > I'm going to fix this one and readd the patch. > > Couple questions: > 1 - Why not a bulk option to remove from a single course? > > I've already submitted this patch and it has been signed off as bug 25606. > > 2 - Could the results report which courses the items were deleted from, at > the very least maybe the number of courses it was removed from? > > This sounds reasonable. I'll look into adding it. > > 3 - I would rather see this use Objects, but CourseReserves could use a > refactor as a whole > > I'm not sure what Objects you are referring to. Any information you can > provide would be great. > > Thanks, > Joe For #3 I meant using: Koha::Course::Reserve->find({itemnumber=> $item->id}); instead of: GetItemCourseReservesInfo(itemnumber => $item->id); Probably we should have a 'course_reserves' function in Item.pm or something, but I think that is beyond scope here -- You are receiving this mail because: You are watching all bug changes.

1 0