August 2020 - Koha-bugs - lists.koha-community.org

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26210 [Bug 26210] issue_id should be consistently set for Lost item handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21231] New: BlockReturnofLostItems does not prevent lost items being found
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21231 Bug ID: 21231 Summary: BlockReturnofLostItems does not prevent lost items being found Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can then be checked in a second time and returned as it is no longer lost. To test: - set an item to lost - set BlockReturnOfLostItems to Block - check the lost item in - Koha says item cannot be returned but also item was lost, is now found - check the item in again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108247&action=e… Bug 11889: [FOLLOW-UP] Tests and new get_shared_shelves subroutine To test: 1) prove t/db_dependent/Virtualshelves.t 2) prove t/db_dependent/Koha/Patrons.t Sponsored-by: Catalyst IT Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108246&action=e… Bug 11889: [QA Follow-up] Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108245&action=e… Bug 11889: [Follow-up] Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61451|0 |1 is obsolete| | Attachment #61452|0 |1 is obsolete| | Attachment #61453|0 |1 is obsolete| | Attachment #61454|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 108244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108244&action=e… Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Cédric Vita <cedric.vita(a)dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11889] Disown a list
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '20

14 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #35) > (In reply to Katrin Fischer from comment #34) > > For the public/shared with public, I think the idea of > > having a general inheriting user is fine. > > If we would have consensus about that, we could perhaps apply the following > algorithm to public lists now ? Would this provide sufficient flexibility? > > When deleting a public list, > if pref GeneralPublicListOwner[?] is a specific userid then > move ownership to that user > elsif pref == current user then > move to current staff member > else > delete list > endif > > And open another report to handle shared lists. And another one for > transferring ownership? Late in the party... Yes Marcel I agree with that. Are you still willing to work on it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25871] New: Add "only library" to OpacItemLocation options
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '20

13 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25871 Bug ID: 25871 Summary: Add "only library" to OpacItemLocation options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The OpacItemLocation preference currently has three choices: - location: location - ccode: "collection code" - callnum: "call number only" I propose that we clarify the labels for these options and add a new one: - location: "library, location, and call number" - ccode: "library, collection code, and call number" - callnum: "library and call number" - library: "only library" The "only library" option would provide an option which was previously only available in the non-XSLT view via the "don't show" option under the "OPACItemsResultsDisplay" : "Availability: Items available for loan: Athens (2), Nelsonville (1)." If this change is acceptable we can WONTFIX Bug 5229 and create a bug to remove the OpacItemsResultsDisplay preference. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 26138] New: Errors if enable_plugins is zero
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '20

13 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 Bug ID: 26138 Summary: Errors if enable_plugins is zero Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Bug 26063 introduced a new way of checking plugins with Koha::Plugins->call(), except there are now errors all over the OPAC if enable_plugins is zero in the config. Trying to submit a simple search throws this error: Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661 This is a bad blocker assuming every instance uses plugins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 24610] New: Let user switch between 'Pay' and 'Write off' mode
by bugzilla-daemon＠bugs.koha-community.org 13 Aug '20

13 Aug '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610 Bug ID: 24610 Summary: Let user switch between 'Pay' and 'Write off' mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This bug will add a way to switch between 'Pay' and 'Write off' mode -- You are receiving this mail because: You are watching all bug changes.

1 20