September 2020 - Koha-bugs - lists.koha-community.org

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Alexis Ripetti <alexis.ripetti(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |alexis.ripetti(a)inLibro.com --- Comment #46 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0. I also changed one thing that seemed weird to me in the C4/Circulation.pm file. Test plan: Before 1) Select a user with active restrictions 2) Make sure finesday=0 for the user category 3) Checkout and return an item (not overdue) : a previous restriction reminder will appear 4) Checkout and return an overdue item : no previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) And finally: 5) prove -v t/db_dependent/Circulation.t All the tests should now pass. Waiting for your comments. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Alexis Ripetti <alexis.ripetti(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106809|0 |1 is obsolete| | --- Comment #45 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- Created attachment 110485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110485&action=e… Bug 14784: Add tests This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0. To test: 1. Apply patches 2. prove -v t/db_dependent/Circulation.t When applying only this patch, one test should fail. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] MARC21: Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110439|0 |1 is obsolete| | --- Comment #18 from David Nind <david(a)davidnind.com> --- Created attachment 110481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110481&action=e… Bug 15436: (follow-up) Fix separator for a single 440 in staff Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] MARC21: Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110304|0 |1 is obsolete| | --- Comment #17 from David Nind <david(a)davidnind.com> --- Created attachment 110480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110480&action=e… Bug 15436: Use semicolon between series name and volume MARC21 dictates that we should be using a ; before $v in 440, 490, 810, 811 and 830. This patch also introduces some additional changes to unify formatting between the various options for cataloguing series: - The separator between multiple series is switched form ; to the now commonly used | with a class for easy change of formatting. - There was some missing logic that prevented the separator to show up correctly between traced and untraced series. - For some series $v was included in the link for others not. Now $v always appears as text and only $a is linked, as this is what we actually search for. To test this: - You should be cataloguing multiple series in different ways, using - deprecated 440 (still present in old data) - 490, Ind. 1 = empty or 0 = not traced - 490, Ind. 1 = 1 = traced in combination with an 8xx field Example (you should try a different combination!) 440 _ _ $aFirst series 490 _ _ $aSecond series ;$v1 490 1 _ $aThird series ;$v1 (this won't show, it will use 830 for display) 830 _ _ $aThird series ;$v1 Without patch: Series: First Series; Second series ; 1Third series: 1 With patch: Series: First series | Second series ; 1 | Third series ; 1 Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15436] MARC21: Use semicolon between series name and volume information
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15050] Nonpublic note searchable from OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Marcy Dunning <library(a)crmm.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library(a)crmm.org --- Comment #12 from Marcy Dunning <library(a)crmm.org> --- We have the same problem with basic searches on names pulling up donors as well as authors. While users can restrict the searches by limiting them to the author field, we want to make the OPAC as easy as possible to use. In some cases we have donors who have given hundreds of items, making a search on that name very confusing. Thanks for working on this. Marcy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26499] New: get_text_wrap columns seems to always expect point units
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26499 Bug ID: 26499 Summary: get_text_wrap columns seems to always expect point units Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I am not sure about this one, and the code seems to be very early code. See bug 5247 - it adds a default of 13.5 points if no left text margin is set. Otherwise the value is 3 times the margin value? I suspect this is to not run directly up against the margin, but I don't understand why? We multiply by 3 no matter what the unit, or the font size, or anything really. Additionally the comparison here is against the return from C4::Creators::PDF->StrWidth which always returns values in points, so we end up comparing other units times three against points? Lastly, we use the value returned for wrapping, but if we determine 4 characters fit and we pass that back, Text::Wrap shortens to one less than the columns value, so only 3 characters will fit on a line https://perldoc.perl.org/Text/Wrap.html "Lines are wrapped at $Text::Wrap::columns columns (default value: 76). $Text::Wrap::columns should be set to the full width of your output device. In fact, every resulting line will have length of no more than $columns - 1 ." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #17 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- (In reply to Martin Renvoize from comment #16) > Thanks Emmi; I hope I didn't come across too negative.. I'd happily pick up > the bug if I had some time to do so.. I'll certainly keep and eye out on it > and try to help with testing/qa as needed. Not at all and thanks beforehand :) Some thoughts I had about this: 1. I'm not sure if owes is quite right. Owings seems more appropriate (or maybe debts?). 2. Maybe we could ditch whole search? Instead we could first search patrons against wanted criteria and then do: my $patrons = Koha::Patrons->filter_by_owings({ 'me.borrowernumber' => { '-in' => \@borrowernumbers }, amount => { '>=' => $max } }); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, this already works great - thx for thinking about all the installers too. Only one small glitch: When editing the notice in tools, you can add fields from issues, but we need old_issues here as the line has alredy been removed from the issues table (this already works for CHECKOUT and CHECKIN notices). Can you pleas provide a small follow-up? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20201] New: Silence warnings in admin/aqplan.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Bug ID: 20201 Summary: Silence warnings in admin/aqplan.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Floody logs distracts from debugging real problems. This will clean up warnings triggered in admin/aqplan.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10