October 2021 - Koha-bugs - lists.koha-community.org

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '21

04 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '21

04 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125648|0 |1 is obsolete| | --- Comment #12 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 125689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125689&action=e… Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '21

04 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #11 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- (In reply to Joonas Kylmälä from comment #10) > Adding Emmi to CC here since you are using the original patch submitted here > 6 years ago. I think this should fix now all problems and if this is merged > you should be able to drop the original patch so if you could sign-off that > would be nice :) We no longer use this feature (most libraries are now using EDitX etc). But I'm happy sign-off nonetheless as soon as I have time :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen(a)koha-suomi.fi --- Comment #10 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- Adding Emmi to CC here since you are using the original patch submitted here 6 years ago. I think this should fix now all problems and if this is merged you should be able to drop the original patch so if you could sign-off that would be nice :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43364|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- Created attachment 125648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125648&action=e… Bug 14999: Make sure order prices are not mixed-up We were shifting the price and replacement price for imported orders only after the line: > $duplinbatch = $import_batch_id and next if $duplifound; This lead to the "replacementprice" and "price" query parameters not being shifted/removed from the list if a duplicate record came across and caused the prices be applied to the next record being imported. To reproduce: 1) Download two records from koha to marcxml file, then cat those: cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Create a new order basket, then "Add to basket" using "From a staged file" option 5) Select both bib1 and bib2 and set price & replacement price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong prices, 99.00! 7) Apply patch and notice the prices are now correctly set to 88.00. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #8 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- So this turned out to be tricky to reproduce but I finally found at least one bug where this happens! So if there is a duplicate matched then we have not shifted away for the previous biblio to be added the replacement and price parameters: > replacementprice => shift( @orderreplacementprices ), > my $price= shift( @prices ) || GetMarcPrice($marcrecord, C4::Context->preference('marcflavour')); So when the line: > $duplinbatch = $import_batch_id and next if $duplifound; is called we are leaving the shifts undone. I wonder if we should go with the originally proposed patch here or just move the shifts to the beginning. If we just move the shifts to the beginning then I feel like it could be a bit more prone to someone re-introducing this bug later if a new field is added. To reproduce this bug: 1) Download two records from koha to marcxml file, then cat those cat bib1.marcxml bib2.marcxml > bibs.marcxml 2) Delete bib2 from koha 3) Stage bibs.marcxml for import 4) Add new basket -> import from a staged file 5) Select both bib1 and bib2 and set price for bib1 to be 99.00 and for bib2 to be 88.00 6) Click save and notice bib2 was imported with the wrong price, 99.00!! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |joonas.kylmala(a)iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '21

02 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylmälä <joonas.kylmala(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #7 from Joonas Kylmälä <joonas.kylmala(a)iki.fi> --- I was checking up what old bug reports I have done and came across this. Definitely a bug in the community version as well and a bug that still exists to this day! Seems pretty major as these are the prices you might send via EDI to the vendor. The bug is probably hard to reproduce but if you read the code you see the problem clearly. The GetImportRecordsRange function might return the imported records in whatever order and we are not matching them in anyway with the parameter data we are getting here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '21

01 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28201 -- You are receiving this mail because: You are watching all bug changes.

1 0