November 2021 - Koha-bugs - lists.koha-community.org

[Bug 29426] New: borrower_debarments.created is "ON UPDATE current_timestamp()"
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29426 Bug ID: 29426 Summary: borrower_debarments.created is "ON UPDATE current_timestamp()" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org https://git.koha-community.org/Koha-community/Koha/src/branch/master/instal… Currently, the table borrower_debarments is created like this: CREATE TABLE `borrower_debarments` ( `borrower_debarment_id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'unique key for the restriction', `borrowernumber` int(11) NOT NULL COMMENT 'foreign key for borrowers.borrowernumber for patron who is restricted', `expiration` date DEFAULT NULL COMMENT 'expiration date of the restriction', `type` enum('SUSPENSION','OVERDUES','MANUAL','DISCHARGE') COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'MANUAL' COMMENT 'type of restriction', `comment` mediumtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'comments about the restriction', `manager_id` int(11) DEFAULT NULL COMMENT 'foreign key for borrowers.borrowernumber for the librarian managing the restriction', `created` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL COMMENT 'date the restriction was updated', PRIMARY KEY (`borrower_debarment_id`), KEY `borrowernumber` (`borrowernumber`), CONSTRAINT `borrower_debarments_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; Looks like there has been a mixup between the created and the updated columns? We have this: `created` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL COMMENT 'date the restriction was updated', Would it not make more sense to have this: `created` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'date the restriction was added', `updated` timestamp NULL DEFAULT NULL ON UPDATE current_timestamp() COMMENT 'date the restriction was updated', ...so that the updated column is actually updated when the row is updated? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 29428] New: Where is css/holds.css ?
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Bug ID: 29428 Summary: Where is css/holds.css ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org [2021/11/05 15:54:43] [WARN] File not found : css/holds.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 17981] New: Add the ability to preview generated notice templates
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Bug ID: 17981 Summary: Add the ability to preview generated notice templates Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.

1 96

[Bug 29492] SPAM
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

1 0

[Bug 5229] OPACItemsResultsDisplay preference must be removed
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 127690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127690&action=e… Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5229] OPACItemsResultsDisplay preference must be removed
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127655|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 127689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127689&action=e… Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5229] OPACItemsResultsDisplay preference must be removed
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 29462] New: OPACPopupAuthorsSearch doesn't work when authors include $d, $e and possible other subfields
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 Bug ID: 29462 Summary: OPACPopupAuthorsSearch doesn't work when authors include $d, $e and possible other subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When using OPACPopupAuthorsSearch with MARC records that have entries like: 700 1 _ ‡aName, Name‡d1960-‡4aut‡969108866 700 1 _ ‡aOthername, Othername‡d1945-t‡957721213 If you select both of those for search, it will create a seach link that includes the content from d and 4 with [] and the search won't work. I am also seeing other issues where I am redirected immediately to /cgi-bin/koha/undefined but not sure yet how to recreate. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 28973] New: Improve Koha::Patron::can_see_patron_infos efficiency
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28973 Bug ID: 28973 Summary: Improve Koha::Patron::can_see_patron_infos efficiency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The method can_see_patron_infos looks up a row in the branches table by branchcode just to get the branchcode it already has. This seems inefficient. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 28365] New: (Bug 19873 follow-up) Make it possible to search on value 0
by bugzilla-daemon＠bugs.koha-community.org 16 Nov '21

16 Nov '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Bug ID: 28365 Summary: (Bug 19873 follow-up) Make it possible to search on value 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 19873 fixed search with value 0. It works in first page but not in other pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17