February 2021 - Koha-bugs - lists.koha-community.org

[Bug 27454] New: Additional patron attributes change sequence on every reload of edit page
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Bug ID: 27454 Summary: Additional patron attributes change sequence on every reload of edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com This is a bit irritating and makes it a little harder when you want to fill out the form quickly. To test: - Create 2 PA_CLASS values and an empty one - Create 3 patron attributes, one for each (I had A, B and the preinstalled SHOW_BCODE) - Open any patron form for editing - Note sequence of additional attributes - Reload page - Verify the sequence changes with reloads -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 27608] New: Correct 'accepted by' inconsistency in suggestion.tt
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 Bug ID: 27608 Summary: Correct 'accepted by' inconsistency in suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 25632] New: Update MARC21 frameworks to update Nr. 30 (May 2020)
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Bug ID: 25632 Summary: Update MARC21 frameworks to update Nr. 30 (May 2020) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: bgkriegel(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org A few changes in bibliographic data format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 27154] New: Koha/Util/SystemPreferences.pm must be removed
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '21

21 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Bug ID: 27154 Summary: Koha/Util/SystemPreferences.pm must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick(a)bywatersolutions.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { We should remove the whole Koha/Util/SystemPreferences.pm package. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 27586] New: Import patrons script has a confirm switch that doesn't nothing!
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '21

20 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586 Bug ID: 27586 Summary: Import patrons script has a confirm switch that doesn't nothing! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If the script misc/import_patrons.pl is run without "--confirm" it reports that is "running in dry-run mode" but it is not! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 27598] New: Add UPLOAD as a built-in system authorized value category
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27598 Bug ID: 27598 Summary: Add UPLOAD as a built-in system authorized value category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The upload tool directs users to create authorized values with the "UPLOAD" category. It would be helpful to add this as a default category with the "is_system" flag set to 1. My hope is that this is a first step towards adding some built-in authorized values which have the UPLOAD category such as one for Audio Alerts. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Katrin Fischer from comment #6) > I think the feature is super nice, but there is a big issue for me as it > will currently only work on the English column names. I hadn't tested it with the new placeholder system, but after rebasing the patch and looking again my tests were successful, with one glitch: If there is a space inside the column name placeholder it won't work. So the SQL you tried: SELECT i.itemnumber, i.itemnumber as Exemplarnummber, [[i.itemnumber| itemnumber for batch]], CONCAT('<a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=', i.biblionumber, '&itemnumber=', i.itemnumber, '#edititem', '\">', i.itemnumber, '</a>' ) AS "itemnumber as edit link" FROM items i "[[i.itemnumber| itemnumber for batch]]" has a space before "itemnumber for batch." With that space removed it works as expected. I think this must be considered a bug in the placeholder parsing, since this query will fail to trigger the expected batch item modification menu: SELECT i.itemnumber AS ' itemnumber for batch' FROM items i -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110697|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 117096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117096&action=e… Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber, not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5697] Automatic linking in guided reports
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 18146] New: C4:: Circulation CanBookBeRenewed lacks full test coverage.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '21

19 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18146 Bug ID: 18146 Summary: C4::Circulation CanBookBeRenewed lacks full test coverage. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com While testing bug 17941, I discovered two cases where test coverage was lacking from t/db_dependent/Circulation.t Around line 2725: if ( $restricted and $restrictionblockrenewing ) { return ( 0, 'restriction'); } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($itemissue->{overdue} and $overduesblockrenewing eq 'blockitem') ) { return ( 0, 'overdue'); } The elseif is never triggered. Around line 2759: if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) { return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew}; return ( 0, "too_soon" ); } elsif ( $itemissue->{auto_renew} ) { return ( 0, "auto_renew" ); } There is no else, but the code never attempts something that would trigger one. To reproduce add: print STDERR "CHECK!\n"; just before the return ( 0, 'overdue') in the first case, and after the elsif's curly brace in the second case. running t/db_dependent/Circulation should not generate the CHECK points. -- You are receiving this mail because: You are watching all bug changes.

1 17