February 2021 - Koha-bugs - lists.koha-community.org

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106623|0 |1 is obsolete| | --- Comment #33 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 116634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116634&action=e… Bug 13961: Fix QA issues This patch fixes following QA issues: FAIL C4/Letters.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL t/db_dependent/Letters.t FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106194|0 |1 is obsolete| | --- Comment #32 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 116633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116633&action=e… Bug 13961: Add unit test Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106193|0 |1 is obsolete| | --- Comment #31 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 116632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116632&action=e… Bug 13961: Add currency format handling Sponsored-by: Koha-Suomi Oy Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106192|0 |1 is obsolete| | --- Comment #30 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 116631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116631&action=e… Bug 13961: Option to include patron's total amount of fines in notices Possibility to show patrons's total amount of fines in notices. Test plan: 1. Apply patch 2. Modify some notice in Tools -> notices & slips 3. See that in the left side of where one can edit message's body is now also a new attribute that one can include to the text: borrowers.totalfine 4. Include that to the text and see it showing the patron's total amount of fines. Sponsored-by: Vaara-kirjastot Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Sally <sally.healey(a)cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24903] New: Special characters like parentheses in numbering pattern cause duplication in recievedlist
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903 Bug ID: 24903 Summary: Special characters like parentheses in numbering pattern cause duplication in recievedlist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Just an example 2016 (No. 12); 2017 (No. 3); 2017 (No. 2); 2017 (No. 1); 2017 (No. 4); 2017 (No. 5); 2017 (No. 6); 2017 (No. 7); 2017 (No. 8); 2017 (No. 9); 2017 (No. 10); 2017 (No. 11); 2017 (No. 12); 2018 (No. 1); 2018 (No. 2); 2018 (No. 3); 2018 (No. 4); 2018 (No. 5); 2018 (No. 6); 2018 (No. 7); 2018 (No. 12); 2018 (No. 9); 2018 (No. 10); 2018 (No. 11); 2019 (No. 1); 2019 (No. 2); 2019 (No. 2); 2019 (No. 4); 2019 (No. 3); 2019 (No. 5); 2019 (No. 6); 2019 (No. 7); 2019 (No. 11); 2019 (No. 7); 2019 (No. 8); 2019 (No. 8); 2019 (No. 9); 2019 (No. 9); 2019 (No. 11); 2019 (No. 9); 2019 (No. 8); 2019 (No. 7); 2019 (No. 6); 2019 (No. 5); 2019 (No. 4); 2019 (No. 3); 2019 (No. 2); 2019 (No. 1); 2018 (No. 12); 2019 (No. 9); 2019 (No. 8); 2019 (No. 1); 2018 (No. 12) Each edit adds at the end since the parentheses break the regex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 24842] New: Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24842 Bug ID: 24842 Summary: Automatic serials missing list feeding does not work when the numbering sequence includes regexp specific characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com We can encounter this issue, when we choose to automatically feed the serials missing list of a subscription (Manual history is uncheck in the subcription planning form). When setting or removing the missing status to a serial issue in the staff interface, the process in the code of adding the issue numering sequence or removing it from the missinglist is based on some regular expression. It's not uncommon that librarians use characters like parenthesis in this sequence, for exemple to add year detail : No 236 (2019) We can even fall upon + or * characters. The consequence is that they are interpreted by the regexp as capturing characters rather then litterals and this causes the process to fail. The result is the creation of multiple doubles in the missing list. This patch aims to solve the problem Test plan : To go faster, choose an existing subscription, click on "Edit/Edit as new(duplicate)" Uncheck Manual history and go to next page Choose whatever simple config for this new subscription Exemple : Frequency : 1/month Subscription length : 12 Subscription start date : 01/01/2020 Subscription end date : nothing Numbering pattern : Volume, number Last value volume :2019 number : 1 Click on "Hide advanced pattern" then "Modify pattern" In the "Numbering formula pattern" zone, add parenthesis around {X}: Vol({X}), No {Y} or an other critical character like + : Vol ({X}), No {Y} + suppl. Fullfill the "Pattern name" : MyTest Save as new pattern Test prediction pattern Save subscription 1) Receive one or two issues on this subscription 2) For the next expected one, set to any missing status rather than arrived one 3) Go to check the missing list in the summary tab of subscription : you can see that the issue had not been added to the list. Install the patch 1) go back to Receive page and set the expected issue as missing. 2) go back to check the missing list : now the issue number is in the list 3) go back to Receive page and set the last missing issue as arrived. 4) go back to missing list : the issue had been removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #225 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 116625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116625&action=e… Bug 14957: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100052|0 |1 is obsolete| | Attachment #109955|0 |1 is obsolete| | Attachment #109956|0 |1 is obsolete| | Attachment #109957|0 |1 is obsolete| | Attachment #109958|0 |1 is obsolete| | Attachment #109959|0 |1 is obsolete| | Attachment #109960|0 |1 is obsolete| | Attachment #109961|0 |1 is obsolete| | Attachment #109962|0 |1 is obsolete| | Attachment #109963|0 |1 is obsolete| | Attachment #116622|0 |1 is obsolete| | Attachment #116623|0 |1 is obsolete| | --- Comment #224 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 116624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116624&action=e… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #223 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 116623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116623&action=e… Bug 14957: Updated schema files -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 10 Feb '21

10 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #222 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 116622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116622&action=e… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0