February 2021 - Koha-bugs - lists.koha-community.org

[Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Nick Clemens <nick(a)bywatersolutions.com> --- Hi Martin, Sorry, I should have read the proposed language closer - pending_checkouts is confusing, I think it can just be 'checkouts' filter_by_has_checkouts I wonder about the methods for filtering Why do you search issues for borrowernumber, then use an in? Would it be simpler to use a single query? I think it is clearer to do something like: $self->search("issues.borrowernumber" => { -not => undef } },{join=>"issues"}); Later for housebound_choosers we do a search related to housebound_roles, then another to borrowernumber - this works, but it comes out as "FROM borrowers JOIN housebound_role JOIN borrowers" -Nick -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24078] New: Convert manual credit 'tab' to a modal
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 Bug ID: 24078 Summary: Convert manual credit 'tab' to a modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: koha-bugs(a)lists.koha-community.org, testopia(a)bugs.koha-community.org Depends on: 24077 Blocks: 17596 As the title says, I think we could modernise the UX for accounts by converting the manual credit tab and form to a modal reached via a new button/accounts toolbar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 [Bug 24077] Convert manual invoice 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.

1 10

[Bug 27640] New: Add credit_types endpoint
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27640 Bug ID: 27640 Summary: Add credit_types endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com We could do with having access to the list of credit_types from the API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14237] Allow bibs to be added to course without items
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, looking good! I like the solution in the GUI for adding individual records. Works well so far! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17409] New: Remove redundant note fields for payments on pay.pl
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409 Bug ID: 17409 Summary: Remove redundant note fields for payments on pay.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently there is an inconsistency with inputting notes on a payment. When you go to pay.pl, there is a note field for input next to each item. However, depending on what you select, there might be a following note field. That field is populated with the all the notes from the pay.pl screen if you click on Pay selected, blank if you click Pay amount, and not even an option if you Write off all. Having individual notes lumped together into one payment line might be confusing and depending on the notes, might not make any sense when the payment is made as a single payment. Because this enhancement is written in hopes that bug 17406 is accepted by the Koha community, I am making this dependent on those enhancements. 1) I suggest that the note fields be removed from the pay.pl page. 2) If bug 17406 is accepted, there will only be two buttons on the pay.pl screen: Pay selected and Write off selected. Regardless of which button is clicked, a summary page should come up showing what was selected, and totals. 3) The summary page should have a checkbox reading (use first note for all items). If checked, only the note field on the first item is active. If unchecked, all note fields are active. The default should be checked. 4) If there is only 1 item selected, the checkbox should not show. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 4037] Inventory tool missing item type filter
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116414|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 116415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116415&action=e… Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4037] Inventory tool missing item type filter
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115231|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 116414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116414&action=e… Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4037] Inventory tool missing item type filter
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 21851] New: Improve style of sidebar forms
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21851 Bug ID: 21851 Summary: Improve style of sidebar forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I propose some minor changes to the way forms in sidebars are styled. My patch will adjust the style of nested fieldsets and list items. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '21

05 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Holly <hc(a)interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc(a)interleaf.ie -- You are receiving this mail because: You are watching all bug changes.

1 0