March 2021 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '21

29 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118922|0 |1 is obsolete| | --- Comment #259 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118938&action=e… Bug 14957: (QA follow-up) Add tooltips This patch adds an info-tooltip to the field rules in the table header to expand on their meaning to reduce the need to read the documentation each time you come to use the configuration tool Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '21

29 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118921|0 |1 is obsolete| | --- Comment #258 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118937&action=e… Bug 14957: (QA follow-up) Button styling This patch updates the action buttons to include btn-default and switched from btn-sm to btn-xs to match other similar UI's found in datatable based admin pages. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '21

29 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118920|0 |1 is obsolete| | --- Comment #257 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118936&action=e… Bug 14957: fix context for batchmod and batchimport Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '21

29 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118919|0 |1 is obsolete| | --- Comment #256 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118935&action=e… Bug 14957: Updated schema files Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 29 Mar '21

29 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118918|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 118934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118934&action=e… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '21

28 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #127 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Tried to QA, not at ease enough with the code, have to pass. QA person: comment 118 have some feedback about the personal processing involved here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '21

28 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #254 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Ok, I submitted what we have so far so others can add here. The patchset introduces several 'features' in my opinion, and we could do better with the DB and classes. In my opinion we would need: 1. A table for rules (done-ish) 2. A table for defining named rule sets 3. A table for assigning 'globally enforced' rule sets to specific places, categories, etc (this is what the patchset does, only, in my opinion). It is a pity we cannot choose rulesets explicitly when importing, but I know we can do it later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '21

28 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #253 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- This patchset has been hanging for too long, and my follow-up patches are my attempt to make it pushable while making it adaptable for future refactorings without major changes. Missing for my PQA stamp: - Translatability in the marc-overlay-rules.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '21

28 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #252 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 118927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118927&action=e… Bug 14957: (QA follow-up) Clarify 'context' param This patch renames the (passed through) 'context' param for 'overlay_context'. I propose doing so, because in Koha-land 'context' has a special meaning, related to C4::Context and it reads ambigous. The patch itself is pretty trivial. Tests should pass: 1. Run: $ kshell k$ prove t/db_dependent/Biblio/MarcOverlayRules.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '21

28 Mar '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #251 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 118926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118926&action=e… Bug 14957: (follow-up) marc_merge_rules_modules removed Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0