May 2021 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #321 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Works as expected :) Note: maxreserves counts the number of holds in the group hold, i.e. it doesn't count it as one. It seems that was intentional. But highlighting that for QA to review. Holds per day and holds total circ rules count the group as 1. Signing off. Though above QA fixes still needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120574|0 |1 is obsolete| | --- Comment #320 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120649&action=e… Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120373|0 |1 is obsolete| | --- Comment #319 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120648&action=e… Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120372|0 |1 is obsolete| | --- Comment #318 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120647&action=e… Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120371|0 |1 is obsolete| | --- Comment #317 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120646&action=e… Bug 15516: Schema updates Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120370|0 |1 is obsolete| | --- Comment #316 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120645&action=e… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120369|0 |1 is obsolete| | --- Comment #315 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120644&action=e… Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120368|0 |1 is obsolete| | --- Comment #314 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- Created attachment 120643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120643&action=e… Bug 15516: Database and installer updates Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7669] Search Results Multiple Cover Image HTML & CSS
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7669 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #13 from Lucas Gass <lucas(a)bywatersolutions.com> --- (In reply to Liz Rea from comment #12) > Coce kind of solves this by handling the cover selection in a different > place, do we still want to deal with this in js/css? > > probably still relevant for local covers? I think this is still relevant for local covers, Syndetics, or any other non-Coce image services. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Victor Grousset/tuxayo <victor(a)tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor(a)tuxayo.net Status|Needs Signoff |Signed Off --- Comment #259 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- It works! :D === Is that expected that Holds allowed (total) isn't taken into account? my $lowestvalue = min( $maxreserves, $remaining_holds_for_record, $remaining_holds_allowed_today ); === I my 1st test, I had a situation where maxreserves 3 holds allowed (total) = 2 holds allowed (daily) = 2 holds per record (count) = 2 And when I ticked one tick, the alert came. The patron had 0 holds and so the record. I did a reset_all and couldn't reproduce. So there might be something wrong, in case this symptom gives you an hint. If not, let's move on I would say. Can't be blocked by a ghost bug that might not actually exist. === Took David's test plan and put it in the commit. And did the following changes: 7) Set the following circulation rules: ↓↓↓ 7) Set the following circulation rules one by one and test that each one alone can trigger the alert: 8) Perform the same above actions on the OPAC ↓↓↓ 8) Set the circulation rules and syspref all to 4+. Check some items and confirm the holds. 9) Perform the same above actions on the OPAC === oops, inverted two patches during a rebase. Anyway, still applies on top of master. -- You are receiving this mail because: You are watching all bug changes.

1 0