May 2021 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120534|0 |1 is obsolete| | --- Comment #297 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 120583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120583&action=e… Bug 14957: Updated schema files Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120533|0 |1 is obsolete| | --- Comment #296 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 120582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120582&action=e… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #23 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Aleisha Amohia from comment #22) > I'm stuck on that JS error, and it looks like the internal note and vendor > note also no longer open in pop up windows. Any thoughts on the datatables > error? - <th colspan="6">Total</th> + <th colspan="7">Total</th> Why? You are not adding a new column. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #255 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #254) > Going to set this back to "Needs Signoff" so it's clearer that someone other > than me should test it. But FYI it is passing the QA tools: root@kohadevbox:koha(bug_15565)$ qa testing 3 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to fai') Processing files before patches |========================>| 7 / 7 (100.00%) Processing files after patches |========================>| 7 / 7 (100.00%) OK Koha/Biblio.pm OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK opac/opac-reserve.pl OK reserve/placerequest.pl OK reserve/request.pl OK t/db_dependent/Reserves/MultiplePerRecord.t Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #295 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 120581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120581&action=e… Bug 14957: (QA follow-up) Update for bug 23271 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #313 from David Cook <dcook(a)prosentient.com.au> --- Still failing the QA tools. I think the pod coverage one can be ignored, as I think that's a QA tool bug. You do need to "chmod +x reserve/hold-group.pl t/db_dependent/Reserves/HoldGroup.t". And it looks like the <title> elements needs to be ordered specific to general. I recall that being a fairly recent requirement: https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC3:_Title_elements… root@kohadevbox:koha(bug_15516)$ qa testing 7 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to fai') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 2) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl FAIL reserve/hold-group.pl FAIL file permissions File must have the exec flag OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t FAIL t/db_dependent/Reserves/HoldGroup.t FAIL file permissions File must have the exec flag Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #22 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- I'm stuck on that JS error, and it looks like the internal note and vendor note also no longer open in pop up windows. Any thoughts on the datatables error? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #254 from David Cook <dcook(a)prosentient.com.au> --- Going to set this back to "Needs Signoff" so it's clearer that someone other than me should test it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm
by bugzilla-daemon＠bugs.koha-community.org 06 May '21

06 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0