June 2021 - Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #337 from David Cook <dcook(a)prosentient.com.au> --- *** Bug 27300 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #336 from David Cook <dcook(a)prosentient.com.au> --- Also, I notice that the text for the release notes say here that this is only for the staff interface, so the change for opac/opac-reserve.pl shouldn't be here at all. Since it's only for the staff interface, the concept of a hold group counting as 1 hold also doesn't make sense, since it would require complicated hold calculations that would vary depending on the interface. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #335 from David Cook <dcook(a)prosentient.com.au> --- Test plan setup: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. perl misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml 0d. restart_all Test: Create a hold group from a group of items 1. Go to intranet search, display some results, click on the first 2 checkboxes and click on 'Place hold' button at the top of the results. (e.g. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test) 2. Search for the "koha" patron (cardnumber 42) 3a. Check the 'Treat as hold group' checkbox 3b. Set pickup location for each item 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) Result: PASS Test: Hold groups count as 1 hold (maxreserves) 1. Change maxreserves to 2 2. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&bib… 3. Note that it says "koha can only place a maximum of 2 total holds" 4. Change maxreserves to 50 Result: FAIL Test: Hold groups count as 1 hold ("Holds allowed (total)") 1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 2. Change "Holds allowed (total)" to 2 3. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&bib… 4. Note that it says "koha can only place a maximum of 2 total holds" 5. Change "Holds allowed (total)" to unlimited (by entering a blank value) Result: FAIL Test: Hold groups count as 1 hold ("Holds allowed (daily)") 1. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 2. Change "Holds allowed (daily)" to 2 3. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&bib… 4. Note it says "No items are available to be placed on hold" and near the bottom of the screen each item says "Daily hold limit reached for patron" Result: FAIL Test: Hold groups count as 1 hold (Patron view) 1. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 2. Note that 2 holds are listed, although each hold is listed as "part of a hold group" (and the links to that hold group are for the same hold group) Result: FAIL Test: Hold groups count as 1 hold (Circulation view) 1. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2. Note that 2 holds are listed, although each hold is listed as "part of a hold group" (and the links to that hold group are for the same hold group) Result: FAIL Test: Hold groups count as 1 hold (OPAC home page view) 1. Go to http://localhost:8080/ 2. Note that the screen says "2 holds pending" Result: FAIL Test: Hold groups count as 1 hold (OPAC user page view) 1. Go to http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-holds 2. Note that the screen says "2 holds" without any indication of them being part of the same hold group Result: FAIL Test: Hold groups count as 1 hold (OPAC place hold view) 1. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=134 2. Note that the screen says "There are no items that can be placed on hold" Result: FAIL Test: Hold groups are disbanded when 1 hold in the group is fulfilled 1. Check in an item of one of the reserved biblios and confirm the hold (e.g. Check in 39999000001310 ) 8. The hold status is changed to Waiting, and all other holds in the hold group are deleted. Result: PASS Note: The "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #334 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Aleisha Amohia from comment #326) > Ah I remember now - yes, a hold group is supposed to be treated as one hold > because when one item from that group is confirmed to fill the hold, the > rest of the group is deleted. > > I'll fix this up. After reading through the code and further testing and thinking, I don't think that's feasible. It would require much more refactoring to achieve that, and I'm not sure that it's worth it. So I think if we pull out the count_grouped() code, then this could actually pass QA, so long as the intention is to create a group of holds, and that fulfilling one hold will clear the other holds. That works well. The counting of the hold group as 1 hold does not work at all though, so perhaps that concept should be abandoned (for now at least). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #333 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 121523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121523&action=e… Bug 15516: Fix shebang in hold-group.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #332 from David Cook <dcook(a)prosentient.com.au> --- I thought that I'd run the QA tools again, as I just noticed that there is a follow-up for the QA tools. My test plan: 0a. Apply the patch 0b. perl ./installer/data/mysql/updatedatabase.pl 0c. qa testing 8 commit(s) (applied to 949f0aa '68 Koha 21.05.00 is here!') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |========================>| 27 / 27 (100.00%) OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t OK t/db_dependent/Reserves/HoldGroup.t Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '21

01 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #331 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 120645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120645 Bug 15516: Allow to reserve first available item from a group of titles Review of attachment 120645: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: reserve/hold-group.pl @@ +1,1 @@ > +#!/usr/bin/env perl This has the wrong shebang. -- You are receiving this mail because: You are watching all bug changes.

1 0