July 2021 - Koha-bugs - lists.koha-community.org

[Bug 28600] New: Variable "$patron" is not available
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 Bug ID: 28600 Summary: Variable "$patron" is not available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: tomascohen(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 18989 In the logs: Variable "$patron" is not available at /kohadevbox/koha/opac/opac-detail.pl line 282 Coming from commit 8de3d9a95f2f3a01b5ed309805d81c698ac8e550 Bug 18989: (QA follow-up) Make controllers use Koha::Biblio->hidden_in_opac - 'category' => $borcat + 'category' => ($patron) ? $patron->categorycode : q{} It's in a sub, and patron is declared outside. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #55 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #49) > There is a problem with these mails. I do not have an attachment, but this > is in the body: > I think that is the way MIME::Lite works but correct me if I'm wrong! I think the attachment gets embedded in the email. So hard to test by looking at the message queue or notices tab, would be good to test with the actual email sent. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #54 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 123022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123022&action=e… Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121038|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 123021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123021&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121037|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 123020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123020&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '21

22 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28725] New: ACQORDER email no longer prints more than one order line
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '21

21 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28725 Bug ID: 28725 Summary: ACQORDER email no longer prints more than one order line Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org In the ACQORDER in the past <order></order> was used to mark the section that shoudl be repeated for each order in the basket. In 20.11 testing with existing templates from our libraries and also the standard template from the wiki, there is always only one order line added to the email. https://wiki.koha-community.org/wiki/Notices_and_Slips_Library#Acquisition_… It doesn't matter if it's all one line or if email/text mails are used. I imagine there might be a workaround using TT syntax, but I couldn't figure it out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 15349] Problem with email pattern check on forms
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '21

21 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Nick Clemens from comment #5) > Could we either: > 1 - add an 'Email display name' field for branches > 2 - add a syspref that adds the branch name to the from field when sending > emails? Hm why not change the validation and allow adding them directly? We have disabled the validation on the branch email field and added things like "Library xy <email(a)email.com>" and it does actually work well in production for a long time. At least in 18.11, but also in my tests with 20.11. At least in our setup where we are also using Reply-to and return-path. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15349] Problem with email pattern check on forms
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '21

21 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Could we either: 1 - add an 'Email display name' field for branches 2 - add a syspref that adds the branch name to the from field when sending emails? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15248] Make it possible to configure duplicate check on bibliographic records
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '21

21 Jul '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 --- Comment #1 from David Cook <dcook(a)prosentient.com.au> --- I like this idea! I was just about to open a ticket because I wanted to add a few indexes (like identifier-standard for 024$a and 022$a and Control-number for 001)to FindDuplicate (which have already been implemented locally). Using record matching rules might really be the best way to do this, since different libraries might have different needs/wants for how to find duplicates. -- You are receiving this mail because: You are watching all bug changes.

1 0