August 2021 - Koha-bugs - lists.koha-community.org

[Bug 21190] New: GDPR: Log successful/unsuccessful login attempts
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Bug ID: 21190 Summary: GDPR: Log successful/unsuccessful login attempts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: vfernandes(a)keep.pt QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Under the auspices of the recently issued European legislation regarding data privacy (GDPR), the Portuguese government has issued a series of mandatory requirements, as well as general recommendations, for software applications that are implemented under the umbrella of public bodies (RCM 41/2018). Since Koha is mostly used by municipalities and universities in Portugal, some of these mandatory requirements need to be address by Koha implementers in Portugal. We believe that this requirement is also useful for the community at large. Here’s a description of the requirement. *** Requirement description *** The application MUST log successful and unsuccessful authentication operations. This is useful, for example, to detect that a user account is being hacked. *** Scope *** Applies in all cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 117

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #206 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- 1. It needs more work, there is something broken (search does not return anything) 2. The UI is not the same as what is advertised in the screenshot, the component part records are display at the top (not on the right) 3. I don't think we need the overhead we introduced with the "show all" link. We call get_component_part_query from C4::XSLT (for that link) and Koha::Biblio (for the list we display). I would suggest to retrieve them all and have a expand/collapse link if we have "too many" element to display. We could then move the get_component_part_query into Koha::Biblio->get_marc_components (Koha::Biblio->get_marc_host is doing that already). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #205 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123562&action=e… Bug 11175: (follow-up) Missed line in previous commit -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123541|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123557&action=e… Bug 11175: (QA follow-up) Take account of bug 15851 We can simplify the code introduced by bug 15851 by moving the 'show_analytics_link' variable assignment into C4::XSLT and thus making the code more DRY. Taking the code in bug 15851 as inspiration this patch also adds proper handling for UseControlNumber vs EasyAnalytics style 773 linking and ensures we only return analytic component parts and no other records containing 773's. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123522|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123556&action=e… Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123521|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123555&action=e… Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123520|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123554&action=e… Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc This fixes the QA tool failure. Signed-off-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123519|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123553&action=e… Bug 11175: (follow-up) Rename routine get_marc_components For consistency with other marc data accessor methods rename the new 'components' method to 'get_marc_components'. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '21

06 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123518|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123552&action=e… Bug 11175: (follow-up) make atomic update idempotent Atomic update tries to insert line into system preferences even if it's already there. This patch fixes that by adding 'IGNORE' to the query, making it idempotent. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0