August 2021 - Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #169 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 123087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123087 Bug 11175: Limit the amount of component parts returned Review of attachment 123087: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=111…) ----------------------------------------------------------------- ::: Koha/Util/Search.pm @@ +34,5 @@ > +=cut > + > +sub get_component_part_query { > + my ($biblionumber) = @_; > + I think perhaps we should be taking UseControlNumber into account here... See opac-details.pl and details.pl controllers for a near the same case. my $cleaned_title = $biblio->title; $cleaned_title =~ tr|/||; my $query = ( C4::Context->preference('UseControlNumber') and $record->field('001') ) ? 'rcn:'. $record->field('001')->data . ' AND (bib-level:a OR bib-level:b)' : "Host-item:($cleaned_title)"; We should really utilise something similar here I feel.. and even better.. start using this in those two locations too.. or rather.. move that handling into XSLT.pm as you have done for the overall show parts code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #168 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- OK, having dug a bit further I'm a little less sure about this patch set.. I love it in theory.. but I feel we're perhaps duplicating code a bit.. The code that governs the 'show analytics' link display already does a similar search but does it within the two -details' controller files.. I feel we should move to using the Util function and XSLT method from here for both cases.. and likely take some notice of UseControlNumber. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14083] Make it possible to record the date the order was placed/sent to the vendor
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 jjennings(a)ait.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jjennings(a)ait.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #167 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- QA Question Should 'Analytics: Show analytics' still display even when the syspref is enabled to display them inline? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14083] Make it possible to record the date the order was placed/sent to the vendor
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Maura Stephens <maura.stephens(a)gmit.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens(a)gmit.ie --- Comment #6 from Maura Stephens <maura.stephens(a)gmit.ie> --- For us, the order date needs to be set and not amendable. Many institutions will have vendor agreements in place with follow up timeframes and reports need to display the initial date the order was sent to the vendor. We had a report in place in 19.11 that could bypass the reopening of a basket for amending a price or switching a fund, but this is no longer the case in 20.11 and this causes major issues now with vendor follow up. Can we please get this bug resolved as a matter of priority. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 27987] New: Canceling an order / deleting item will result in warning even though there was no problem
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27987 Bug ID: 27987 Summary: Canceling an order / deleting item will result in warning even though there was no problem Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This is due to the return result from Koha::Item::safe_delete being different than what DelOrder expects. We should be checking for the correct return value in DelOrder. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #166 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123410&action=e… Bug 11175: (QA follow-up) We lost Encode somewhere This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it somewhere along the way and broke the feature as it uses 'decode'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13307] Create a link to the last advanced search in search result page (OPAC)
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28784 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25321] New: Move translatable strings out of strings.inc into merge-record.js
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Bug ID: 25321 Summary: Move translatable strings out of strings.inc into merge-record.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 21156 Strings which were put in strings.inc for translation purposes can now be wrapped in the new translation function and put in the various JavaScript files where they're used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '21

03 Aug '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #165 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 123406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123406&action=e… Bug 11175: (QA follow-up) Move preference to 'Display' The 'ShowComponentRecords' preference was displaying under the 'Export' section in the cataloging system preferences tab. As a display related feature, I felt it was more appropriate to put it into the 'Display' section. -- You are receiving this mail because: You are watching all bug changes.

1 0