January 2022 - Koha-bugs - lists.koha-community.org

[Bug 29763] New: Patron information - terminology; borrowernumber
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29763 Bug ID: 29763 Summary: Patron information - terminology; borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On the patron details page the 'Borrowernumber' is shown on the top left patron information section. 'borrowernumber' is used as part of the query/URL and is the assigned number given to a patron in the database. It is also used in other areas of the staff interface, such as the patron batch modification tool (Tools > Patrons > Patron batch modification) - see the tab 'By borrowernumber', where you can enter a list of 'borrowernumbers' to modify. Should this be renamed to something more human friendly rather than what the system uses to identify this field? Such as 'Patron number'. Our terminology list says we should use patron, rather than member or borrower: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 29831] New: Fix incorrect use of _() in .js files
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29831 Bug ID: 29831 Summary: Fix incorrect use of _() in .js files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr We need to make sure that we are using __() in .js files, instead of the _() from .tt files. >From bug 29688 comment 2: background-job-progressbar.js: humanMsg.displayMsg( '' + _('Import of record(s) failed: ') + textStatus + ''+xml.responseText, { className: 'humanError' } ); calendar.js: is_date_after: _("Validation error to be shown, i.e. End date must come after start date") checkouts.js: $(selected_option).text(_("%s (current status)").format($(selected_option).text())); datatables.js: var search_title = _("%s search").format(title); holds.js: _("This pickup location is not allowed according to circulation rules") + letter.js: $(sms_counter).html(length + "/" + sms_limit + _(" characters")); onboarding.js:function _(s) { return s; } // dummy function for gettext pages/results.js: div.find(".hint").html(_("Coce image from Amazon.com")); pages/results.js: div.find(".hint").html(_("Coce image from Google Books")); pages/results.js: div.find(".hint").html(_("Coce image from Open Library")); pages/tags-review.js: // window.alert(_("AJAX approved tag: ") + tag); pages/tags-review.js: // window.alert(_("AJAX rejected tag: ") + tag); pages/tags-review.js: $('#test_button').html("" +_(" Test")); pages/tags-review.js: // window.alert(_("Click detected on ") + event.target + ": " + $(event.target).html); rotating-collections.js: if(confirm(_("Are you sure you want to delete this rotating collection?"))){ xmlControlfield.js: alert(_("AJAX error: receiving data from %s").format(settings.url)); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 6734] Show location in full and brief subscription history in OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show location in serials |Show location in full and |history table |brief subscription history | |in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6734] Show location in serials history table
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 129231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129231&action=e… Bug 6734: (QA follow-up) Fix punctuation and TT filters * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6734] Show location in serials history table
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129118|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 129230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129230&action=e… Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6734] Show location in serials history table
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 29801] New: Holds reminder cron not finding notice for all libraries
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 Bug ID: 29801 Summary: Holds reminder cron not finding notice for all libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: nick(a)bywatersolutions.com Depends on: 28153 When running the holds reminder cron, it will give a "no letter found" error if the only HOLDS_REMINDER email is for all libraries rather than a specific library. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 29237] New: When deleting funds from an inactive budget, the results page returns to a different budget
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29237 Bug ID: 29237 Summary: When deleting funds from an inactive budget, the results page returns to a different budget Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: valerie(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In Administration/Budgets, I am in the "inactive budgets" tab, deleting funds under a specific budget. (In this instance, budget period #29.) When I select "delete" for the fund, it opens a new page to verify that I want to delete this budget. After it completes the deletion, it goes to a different budget, an active budget. (In this case, budget period #30). I confirmed that the fund was deleted as expected from the inactive budget, but with the page going to a different budget when complete, a user could easily delete something unintended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 29559] New: Update creates "unexpected type" entries for standard codes in debit and credit types
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 Bug ID: 29559 Summary: Update creates "unexpected type" entries for standard codes in debit and credit types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: martin.renvoize(a)ptfs-europe.com After an update from 18.11 to 20.11.11 we notice that there are a lot of "Unexpected type found during upgrade (Voided)" in the patron accounts. It looks like 19.12.00.027 / Bug 24532 and maybe others are related to this. Following entries have been added: select * from account_credit_types; LOST select * from account_debit_types; Pay W It could be related to voiding entries, but I am not fully understanding the issue yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '22

09 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Owen Leonard from comment #2) > The item search table is rendered server-side, so all sorting happens > server-side. This eliminates some of our standard sorting methods, like > embedding a sortable string in a title tag. > > Renaming the column "cn_sort" has the right effect for the purposes of > sorting: The column name "cn_sort" is passed to the query and the rows are > sorted correctly by call number. > > Unfortunately this breaks the column filter: "cn_sort" is an ambiguous > column name for the purposes of the query because of biblioitems.cn_sort. > I'm not sure if there is a good way to handle this besides adding some > conditional code specific to these columns. > > Suggestions welcome! Hi Owen, does that mean we should expect similar issues for date sorting for server side rendered tables? Or is it something specific to how this table was implemented? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0