October 2022 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135523|0 |1 is obsolete| | --- Comment #225 from geraud.frappier(a)inlibro.com --- Created attachment 142436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142436&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135522|0 |1 is obsolete| | --- Comment #224 from geraud.frappier(a)inlibro.com --- Created attachment 142435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142435&action=e… Bug 12446: Fix typos Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> JD Amended patch: squashed and edited commit message Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135521|0 |1 is obsolete| | --- Comment #223 from geraud.frappier(a)inlibro.com --- Created attachment 142434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142434&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135520|0 |1 is obsolete| | --- Comment #222 from geraud.frappier(a)inlibro.com --- Created attachment 142433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142433&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135519|0 |1 is obsolete| | --- Comment #221 from geraud.frappier(a)inlibro.com --- Created attachment 142432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142432&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13600] XSLT: 8xx not showing if there is no 4xx
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #38 from Heather <heather_hernandez(a)nps.gov> --- Here's some Cataloger Opinions on Punctuation (in case it's helpful!): I looked at the sample records--lots of fields seem to be missing required indicators, but I guess that doesn't affect this? First record, "This is a series with multiple 8xx but no 4xx" has correct punctuation. Second record, "This is a series with multiple 440 and 8xx but no 490" has incorrect punctuation in second 440 field: "Chronicles of Prydain ǂv 2" should be "Chronicles of Prydain ;ǂv 2" It's the same in the 3rd records, "This is a series with 8xx and 490," with the 490 lacking a semicolon preceding the subfield v. Given that this MARC record lacks the required semicolon preceding the subfield v, yet a semicolon is supplied in the display, it seems that Koha is supplying semicolons as display constants, but this is not permitted in MARC21 for field 490: https://www.loc.gov/marc/bibliographic/bd490.html The only display constants permitted in MARC21 are optional parentheses enclosing the display of the entire field. So catalogers are required to enter a semicolon preceding a subfield v in all MARC21 series fields (4XX &/or 8XX), so Koha shouldn't be supplying semicolon display constants. I think this supplying of a semicolon display constant is why there are weird double-semicolons. So maybe a developer could apply Developer Code Magic to stop Koha from supplying these unallowed semicolon display constants? As for the behavior of record "This is a series with 440 and 490" not displaying the 490 with a first indicator of 1, that seems like correct behavior--that is an incorrect indicator, since "1" should only be used when the record has a paired 8XX field to provide the series added entry. (The correct indicator in the absence of a paired 8XX field is 490 0_). --h2 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135544|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135545|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '22

21 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 geraud.frappier(a)inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135544|0 |1 is obsolete| | --- Comment #220 from geraud.frappier(a)inlibro.com --- Created attachment 142431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142431&action=e… Bug 12446: Remove can_be_guarentee is_boolean to put it back in another patch This patch resolve merge conflit and add the instantiation of the variable "my $categories" that was missing in memberentry.pl. -- You are receiving this mail because: You are watching all bug changes.

1 0